Mixxx

Mismatching allocation and deallocations

Bug #410833 reported by Bill Egert
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
RJ Skerry-Ryan
Mixxx 1.7.3

Bug Description

Running cppcheck 1.34 against Mixxx 1.7.0 yeilds:

% cppcheck -f -a -q .
[src/bpm/bpmdetector.cpp:64]: (error) Mismatching allocation and deallocation: BpmDetector::windowedSamples
   delete -> delete[]
[src/midiobjectcoremidi.cpp:171]: (error) Mismatching allocation and deallocation: buf
   delete -> delete[]
[src/soundsourcemp3.cpp:593]: (error) Mismatching allocation and deallocation: inputbuf
   delete -> delete[]
[src/trackinfoobject.cpp:161]: (error) Mismatching allocation and deallocation: TrackInfoObject::m_fBpmFactors
   malloc -> free, not malloc -> delete

Revision history for this message
Albert Santoni (gamegod) wrote :

These look valid...

Changed in mixxx:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Oliver Stöneberg (kidman) wrote :

I added a patch, that fixes mismatched allocations and deallocation by the leatest cppcheck (post-1.39 SVN).

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Thanks Kidman,

I just committed your patch. How would you like your name to appear in the contributions list?

Cheers,
RJ

Changed in mixxx:
milestone: none → 1.7.3
assignee: nobody → RJ Ryan (rryan)
status: Triaged → Fix Committed
Revision history for this message
Oliver Stöneberg (kidman) wrote :

I updated my display name, which can be used in the contributions list.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5209

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.