possible buffer overrun bug in command line client

[Monty Taylor]

The following are from Domas. Note the bit "near 'r/*!40103" ... that r shouldn't be there. Looks like an off-by-one bug.

Also - we should document something like this as a good way to catalog things that we've removed.

flu:dr midom$ mysqldump --no-create-info --extended-insert=0 --skip-add-locks wikidb watchlist | drizzle -f wikidb
ERROR 1193 (HY000) at line 7: Unknown system variable 'CHARACTER_SET_CLIENT'
ERROR 1193 (HY000) at line 7: Unknown system variable 'CHARACTER_SET_RESULTS'
ERROR 1193 (HY000) at line 7: Unknown system variable 'COLLATION_CONNECTION'
ERROR 1193 (HY000) at line 7: Unknown system variable 'NAMES'
ERROR 1298 (HY000) at line 7: Unknown or incorrect time zone: '+00:00'
ERROR 1193 (HY000) at line 7: Unknown system variable 'SQL_MODE'
ERROR 1064 (42000) at line 22: You have an error in your SQL syntax; check the manual that corresponds to your Drizzle server version for the right syntax to use near 'r/*!40103 SET TIME_ZONE=@OLD_TIME_ZONE */' at line 1
ERROR 1193 (HY000) at line 22: Unknown system variable 'SQL_MODE'
ERROR 1193 (HY000) at line 22: Unknown system variable 'CHARACTER_SET_CLIENT'
ERROR 1193 (HY000) at line 22: Unknown system variable 'CHARACTER_SET_RESULTS'
ERROR 1193 (HY000) at line 22: Unknown system variable 'COLLATION_CONNECTION'
flu:dr midom$ mysqldump --no-create-info --extended-insert=0 --skip-add-locks wikidb watchlist | egrep -v NOTHINGNOTHINGNOTHING | drizzle -f wikidb
ERROR 1193 (HY000) at line 7: Unknown system variable 'CHARACTER_SET_CLIENT'
ERROR 1193 (HY000) at line 7: Unknown system variable 'CHARACTER_SET_RESULTS'
ERROR 1193 (HY000) at line 7: Unknown system variable 'COLLATION_CONNECTION'
ERROR 1193 (HY000) at line 7: Unknown system variable 'NAMES'
ERROR 1298 (HY000) at line 7: Unknown or incorrect time zone: '+00:00'
ERROR 1193 (HY000) at line 7: Unknown system variable 'SQL_MODE'
ERROR 1298 (HY000) at line 22: Unknown or incorrect time zone: 'SYSTEM'
ERROR 1193 (HY000) at line 22: Unknown system variable 'SQL_MODE'
ERROR 1193 (HY000) at line 22: Unknown system variable 'CHARACTER_SET_CLIENT'
ERROR 1193 (HY000) at line 22: Unknown system variable 'CHARACTER_SET_RESULTS'
ERROR 1193 (HY000) at line 22: Unknown system variable 'COLLATION_CONNECTION'

[Jay Pipes (jaypipes)]

I don't think this has to do with the command line client at all. I think this has only to do with the code that you changed, Monty, in sql_lex.cc which handles /*! comments in the parser, no?

[Monty Taylor (mordred)]

Jay Pipes wrote:
> I don't think this has to do with the command line client at all. I
> think this has only to do with the code that you changed, Monty, in
> sql_lex.cc which handles /*! comments in the parser, no?

I don't think so ... look at the leading r in front of the comment...

> ** Changed in: drizzle
> Importance: Undecided => Low
>
> ** Changed in: drizzle
> Status: New => Confirmed
>
> ** Changed in: drizzle
> Assignee: (unassigned) => Monty Taylor (mordred)
>

[Monty Taylor (mordred)]

After having just fixed another buffer overrun bug in the command line client which was caused by sprintf into a statically sized buffer and browsing through the code, I think there are probably more than one of these. I'm going to give drizzle.cc a good going over.

[Andrew Hutchings (linuxjedi)]

Can no longer reproduce with current trunk. As a side note, please use drizzledump to retrieve data from MySQL servers as it will do on-the-fly conversions.