Empathy shows wrong icon for notifications

[Vish]

Binary package hint: notify-osd

Empathy shows its own icon for notifications,
/usr/share/icons/Human/scalable/status/notification-message-im.svg icon needs to be used , instead Empathy uses its own icon for notifications.

Since notify-osd uses its own set of icons this icon switch needs to be done in the notify-osd.

ProblemType: Bug
Architecture: i386
Date: Thu Aug 6 17:46:27 2009
DistroRelease: Ubuntu 9.10
GtkTheme: VDust Sand
IconTheme: Aero-CrazyFolk-RC1
Lsusb:
 Bus 002 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
 Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
 Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
 Bus 004 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
 Bus 005 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
MachineType: Acer, inc. Aspire 5670
Package: notify-osd 0.9.16-0ubuntu1
ProcCmdLine: BOOT_IMAGE=/boot/vmlinuz-2.6.31-5-generic root=UUID=070f2a33-a167-4055-9429-e626203105d4 ro splash
ProcEnviron:
 LANG=en_IN
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-5.24-generic
RelatedPackageVersions:
 xserver-xorg 1:7.4+3ubuntu5
 libgl1-mesa-glx 7.5-1ubuntu1
 libdrm2 2.4.12-1ubuntu1
 xserver-xorg-video-intel 2:2.8.0-0ubuntu2
 xserver-xorg-video-ati 1:6.12.99+git20090629.f39cafc5-0ubuntu5
SourcePackage: notify-osd
Uname: Linux 2.6.31-5-generic i686
WindowManager: compiz
dmi.bios.date: 02/08/06
dmi.bios.vendor: Acer
dmi.bios.version: v1.3219
dmi.board.name: Bodensee
dmi.board.vendor: Acer, Inc.
dmi.board.version: Not Applicable
dmi.chassis.type: 1
dmi.chassis.vendor: , Inc.
dmi.chassis.version: N/A
dmi.modalias: dmi:bvnAcer:bvrv1.3219:bd02/08/06:svnAcer,inc.:pnAspire5670:pvrNotApplicable:rvnAcer,Inc.:rnBodensee:rvrNotApplicable:cvn,Inc.:ct1:cvrN/A:
dmi.product.name: Aspire 5670
dmi.product.version: Not Applicable
dmi.sys.vendor: Acer, inc.

[Vish (vish)]

Attaching screenshot of the notification.

This problem exists while using the Human icon theme also.

I guess this needs to be done by Karmic , since Empathy is now the default im client.

[Pedro Villavicencio (pedro)]

icon im-message-new is called from empathy, the change should be there instead. reassigning.

[Mirco Müller (macslow)]

You rather want Empathy to use the symbolic name "notification-message-im", and not the full icon-theme-secific path.

[Robert Ancell (robert-ancell)]

This will require a UI freeze exception:
https://wiki.ubuntu.com/UserInterfaceFreeze

[Vish (vish)]

UI Freeze exception request sent to the doc mailing list >
https://lists.ubuntu.com/archives/ubuntu-doc/2009-September/013638.html

Reason:
" In Ubuntu 9.10 [Karmic Koala] , empathy is the default IM client and the
default notification daemon is notify-osd.

Empathy ,at present, uses its own image icon [im-message-new] for the
new message notifications. Rather it should use the icon ,
notification-message-im , from the set provided by notify-osd. "

Oh... and the lines which need a change are in:
/src/empathy-event-manager.c
*** 377,385 ****
    channel = empathy_tp_chat_get_channel (tp_chat);

    if (event != NULL)
! event_update (approval->manager, event, EMPATHY_IMAGE_NEW_MESSAGE, header, msg);
    else
! event_manager_add (approval->manager, sender, EMPATHY_IMAGE_NEW_MESSAGE, header,
        msg, approval, event_text_channel_process_func, NULL);

    empathy_sound_play (empathy_main_window_get (),

[Martin Pitt (pitti)]

Looks fine, approved.

[Sebastien Bacher (seb128)]

unsubscribing the sponsors since kenvandine said the changes are crashy, could you also open a bug upstream to discuss the changes if that's not already done since upstream already complained in the past about ubuntu doing changes without letting them know about those?

[Sebastien Bacher (seb128)]

the comment was rather for bug #340180 but it seems bzr has all the changes

[Launchpad Janitor (janitor)]

This bug was fixed in the package empathy - 2.27.92-1ubuntu3

---------------
empathy (2.27.92-1ubuntu3) karmic; urgency=low

  [Ken VanDine]
  * debian/control:
    - Added libindicate-gtk-dev and libindicate-dev (>=0.2.0) to build depends
  * debian/patches/30_raise_not_toggle.patch:
    - Always raise contact list when clicked (LP: #392153)
  * debian/patches/99_autoconf.patch added

  [Robert Ancell]
  * debian/patches/10_use_notify_osd_icons.patch:
    - Use the notify-OSD icons for new messages (LP: #409828)
  * debian/patches/20_libindicate.patch:
    - Integrate into messaging menu (LP: #340180)
  * debian/control:
    - Remove Debian VCS links as they confuse debcheckout

 -- Ken VanDine <email address hidden> Mon, 21 Sep 2009 14:34:40 +0200

[Santiago Roland (santiago-roland)]

There is a missing icon in empathy notification when new message incomes in the system tray... this is my screenshot.... the default theme in Karmic is Humanity... what icon should be shown? it can be replaced?

thanks,

[Robert Hall (reh07)]

Using Karmic 9.10:

~$ aptitude show empathy
Package: empathy
State: installed
Automatically installed: no
Version: 2.28.1.1-0ubuntu1

~$ aptitude show notify-osd-icons
Package: notify-osd-icons
State: installed
Automatically installed: no
Version: 0.3

The only icon that is missing is the one triggered when there's a new incoming message. I get the same icon as the one depicted in #11 posts' attachment.
Is this the same bug or a misconfiguration in our part?

[Christopher Blay (blayde)]

I have the blinking icon missing as well but I would imagine it needs to be addressed in a new bug report