failed to run the statistics tool

[Didier Barvaux]

Reported by Josephine Kakande on the mailing list: https://lists.launchpad.net/rohc/msg00006.html

I'm trying to test the statistics tool in rohc-1.2.0. Running

    $auto.pl

generated this error:
'Use of uninitialized value in addition (+) at ./stats.pl line 249, <PACKETS_SIZE> line 1'

[Didier Barvaux (didier-barvaux)]

Confirmed on an up-to-date Gentoo system.

[Didier Barvaux (didier-barvaux)]

The problem also affects the trunk.

[Didier Barvaux (didier-barvaux)]

The statistics tool is done the wrong way. It runs the non-regression tool and parses the generated output. The problem reported in this bug is caused by changes in log messages: the string 'Size of IP packet' became 'size of IP packet' some time ago.

[Didier Barvaux (didier-barvaux)]

Some other problems cause the statistics tool to not run correctly:
 - Some scripts must be executable while they are not:
     - statistics/analyse_log.pl
     - statistics/auto.pl
     - statistics/gnuplot.sh
     - statistics/stats.pl
     - statistics/test.sh
 - The library and the non-regression tool must be built before running the statistics tool.
 - The binary of the non-regression tool is not test/test but test/.libs/test. The first one is a
   shell script setup by the autotools so that someone may run the binary from the source
   directory without installing it. The statistics/test.sh script redefines the system variable
   $PATH and this causes many troubles to the shell script generated by the autotools.
 - The statistics/list_all.txt file contains all the paths to network captures. One of these paths
   does not exist anymore. The path 'ipv4/udp/rtp/divers' contained a French word and was
   moved some time ago to 'ipv4/udp/rtp/misc'.

Moreover:
 - The statistics tool does not check the presence of the scripts or binaries it calls. It does not
   check either if the scripts or binaries are excutable.
 - The statistics tool contains many sentences in French.
 - The statistics tool MUST NOT contain its own list of network captures. Information is
   duplicated between the statistics tool and the non-regression tool.The list of reference
   is the one of the non-regression tool.
 - The statistics tool MUST NOT grab sentences in the library logs because the debug traces
   may change without notice.

[Didier Barvaux (didier-barvaux)]

For the bugfix-only branch 1.2.x:
 - Change the string 'Size of IP packet' for 'size of IP packet' in the script
   statistics/analyse_log.pl.
 - Make the perl and shell scripts of the statistics subdirectory executable.
 - Update the instructions given in the INSTALL file to indicate that the library
   and non-regression tool must be built before running the statistics tool.
 - Change the name of the $PATH variable in the statistics/test.sh script.
 - Replace the path 'ipv4/udp/rtp/divers' by 'ipv4/udp/rtp/misc' in the
   statistics/list_all.txt file.

For the trunk: the statistics tool is broken by design, so rework it completely.

[Didier Barvaux (didier-barvaux)]

Schedule the correction for the next 1.2.1 release.

[Didier Barvaux (didier-barvaux)]

Schedule the correction for the next 1.3.0 release.

[Didier Barvaux (didier-barvaux)]

Committed in the 1.2.x branch: http://bazaar.launchpad.net/~didier-barvaux/rohc/1.2.x/revision/98

[Didier Barvaux (didier-barvaux)]

Change target release from 1.3.0 to 1.4.0.

[Didier Barvaux (didier-barvaux)]

I have just added a new statistics application to the trunk. See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/200 for the commit. See FAQ #1218 to learn how to use the new statistics application.

I have also removed the old scripts that were broken. See http://bazaar.launchpad.net/~didier-barvaux/rohc/main/revision/202 for the commit.

[Didier Barvaux (didier-barvaux)]

The statistics scripts won't be fixed in the 1.3.x branch. Too much work.