sitecopy - sftp protocol doesn't work with openssh 1.4.2pl-1

[John MacFarlane]

After upgrading to dapper beta, I could no longer use sitecopy to update my website (sftp protocol). Sitecopy would ask for the remote site's password and then hang. After some searching, I found a fix here:

http://www.lyra.org/pipermail/sitecopy/2005-November/001755.html

I applied the patch and sitecopy worked again.

[Reed Snellenberger (rsnellenberger)]

>-----Original Message-----
>From: Silvestre Zabala [mailto:<email address hidden>]
>Sent: Wednesday, November 02, 2005 12:32 PM
>To: Debian Bug Tracking System
>Subject: Bug#337122: sitecopy: sftp protocol doesn't work with
>openssh >= 1:4.2p1-1
>
>Package: sitecopy
>Version: 1:0.16.1-1
>Severity: normal
>Tags: patch
>
>Hello,
>
>the sftp protocol doesn't work with openssh >= 1:4.2p1-1
>because the new sftp command doesn't print a prompt after
>connecting to the remote server any longer if STDIN is not a tty.[1]
>
>Thus this trivial patch is enough to make it work again:
>
>--- sftpdriver.c 2005-06-29 11:44:47.000000000 +0200
>+++ sftpdriver.c 2005-11-02 19:09:55.000000000 +0100
>@@ -140,7 +140,6 @@
> }
> close(c_in);
> close(c_out);
>- read_sftp(sess); /* wait for prompt */
> return SITE_OK;
> }
>
>Best regards,
> Silvestre
>
>
>[1]
>http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sftp.c.di
>ff?r1=1.65&r2=1.66&f=h
>
>--
>http://silvestre.zabala.name/
>

--
Reed Snellenberger
GPG KeyID: 5A978843
rsnellenberger-at-houston.rr.com

[Joe Orton (joe-manyfish)]

On Sat, Nov 05, 2005 at 11:44:21AM -0600, Reed Snellenberger wrote:
> >the sftp protocol doesn't work with openssh >= 1:4.2p1-1
> >because the new sftp command doesn't print a prompt after
> >connecting to the remote server any longer if STDIN is not a tty.[1]
> >
> >Thus this trivial patch is enough to make it work again:

Obvious question... will this still work OK with older versions of
OpenSSH?

joe

> >
> >--- sftpdriver.c 2005-06-29 11:44:47.000000000 +0200
> >+++ sftpdriver.c 2005-11-02 19:09:55.000000000 +0100
> >@@ -140,7 +140,6 @@
> > }
> > close(c_in);
> > close(c_out);
> >- read_sftp(sess); /* wait for prompt */
> > return SITE_OK;
> > }
> >
> >Best regards,
> > Silvestre
> >
> >
> >[1]
> >http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sftp.c.di
> >ff?r1=1.65&r2=1.66&f=h
> >
> >--
> >http://silvestre.zabala.name/
> >
>
> --
> Reed Snellenberger
> GPG KeyID: 5A978843
> rsnellenberger-at-houston.rr.com
>
>
> _______________________________________________
> sitecopy maillist - <email address hidden>
> http://dav.lyra.org/mailman/listinfo/sitecopy

[Silvestre Zabala (silvestre-zabala)]

* Joe Orton:

> If someone wants to get this patch integrated then the extra read call
> needs to be done conditionally on what version of OpenSSH is used,
> AFAICT; otherwise it's just going to break with older versions at the
> expense of working with newer versions.

Yes, and that was the exact reason why I sent the patch to the Debian BTS.
It should be included in the Debian package until you decide to drop the
support for old openssh versions, or someone whips up a better patch.

Until that happens I provide a Debian package at

deb http://silvestre.zabala.name/debian/ ./
deb-src http://silvestre.zabala.name/debian/ ./

Best regards,
  Silvestre

--
http://silvestre.zabala.name/

[John MacFarlane (jgm)]

After upgrading to dapper beta, I could no longer use sitecopy to update my website (sftp protocol). Sitecopy would ask for the remote site's password and then hang. After some searching, I found a fix here:

http://www.lyra.org/pipermail/sitecopy/2005-November/001755.html

I applied the patch and sitecopy worked again.

[Reed Snellenberger (rsnellenberger)]

Source: sitecopy
Source-Version: 1:0.16.3-1

We believe that the bug you reported is fixed in the latest version of
sitecopy, which is due to be installed in the Debian FTP archive:

sitecopy_0.16.3-1.diff.gz
  to pool/main/s/sitecopy/sitecopy_0.16.3-1.diff.gz
sitecopy_0.16.3-1.dsc
  to pool/main/s/sitecopy/sitecopy_0.16.3-1.dsc
sitecopy_0.16.3-1_i386.deb
  to pool/main/s/sitecopy/sitecopy_0.16.3-1_i386.deb
sitecopy_0.16.3.orig.tar.gz
  to pool/main/s/sitecopy/sitecopy_0.16.3.orig.tar.gz

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to <email address hidden>,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Reed Snellenberger <email address hidden> (supplier of updated sitecopy package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing <email address hidden>)

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sun, 16 Apr 2006 22:13:26 -0500
Source: sitecopy
Binary: sitecopy
Architecture: source i386
Version: 1:0.16.3-1
Distribution: unstable
Urgency: low
Maintainer: Reed Snellenberger <email address hidden>
Changed-By: Reed Snellenberger <email address hidden>
Description:
 sitecopy - A program for managing a WWW site via FTP, DAV or HTTP
Closes: 337122 358387 362147
Changes:
 sitecopy (1:0.16.3-1) unstable; urgency=low
 .
   * New upstream release (Closes: #362147)
   * Added patch to fix "sftp protocol doesn't work with openssh >= 1:4.2p1-1" (Closes: #337122)
   * Adding SSL support (Closes: #358387)
Files:
 ff269392f4d3c735ad3d7fc5bbd38175 665 web extra sitecopy_0.16.3-1.dsc
 df48499ad81b333a9d255c1709e09a1a 961799 web extra sitecopy_0.16.3.orig.tar.gz
 cdd2dea4990ab8fedc98c71e5eaf5616 22818 web extra sitecopy_0.16.3-1.diff.gz
 18baa55fa7f8f54a2e409da76908f2cc 173328 web extra sitecopy_0.16.3-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)

iD8DBQFEV7fHBEnrTWk1E4cRAlZvAJ9paLto4JgJzwYB53YN7CsWmdXB8QCeN+WE
VbnCrfGk4sKdNGsrWf413Qo=
=jl0O
-----END PGP SIGNATURE-----

[Thomas Güttler (guettli)]

Yes, I have the same problem with sftp. It worked before the update to Dapper.
Unfortunately the link to the fix is not accessable at the moment.

[Kartik Mistry (kartik.mistry)]

I will fix this in next version upload to Debian. Thanks for filling bug report!

[Kartik Mistry (kartik.mistry)]

Please see: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=337122

This bug is done!

[Kai Kasurinen (kai-kasurinen)]

 Thanks for the bug report. I'm closing it because the bug has been fixed in Edgy.

sitecopy (1:0.16.3-1) unstable; urgency=low

  * New upstream release (Closes: #362147)
  * Added patch to fix "sftp protocol doesn't work with openssh >= 1:4.2p1-1" (Closes: #337122)
  * Adding SSL support (Closes: #358387)

 -- Ubuntu Archive Auto-Sync <email address hidden> Thu, 15 Jun 2006 15:38:11 +0100

[yannek (yannek-deactivatedaccount)]

I'd like to have this bug reopend, as the namly problem occurs again with the 1:0.16.3-10 version. It got fixed _again_ in the -13 revision.(According to Ubuntu and Debian changelogs.)
That causes it to be broken again with gutsy.
An update to hardy is not a sensible option yet. A backported fix would be highly appreciated.

A hearty Thank you! in advance.