Application crashes if initial login throws an exception

[Hosam Aly]

OpenERP - GTK Client - v5.0.0 - Python 2.6.2

The application crashes if an error occurs during initial login. Any exception that is thrown from the login method is not being captured, and the application crashes without showing an error dialog or saying what happened.

[Hosam Aly (hosamaly)]

An example that shows this bug in action:
1. Open the application.
2. In the initial login screen, enter a password that contains a unicode character (see bug #409345)
3. Press Enter or OK. The application crashes.

[Hosam Aly (hosamaly)]

Why was this bug moved to OpenObject Server, I wonder? It seems to me like a bug in the client code. Exceptions thrown from the login process are not being captured. This can happen with any type of exception, whether it comes from the server or any other problem on the client side (e.g. connection breakdown during login).

The client code should be fixed to capture such exceptions and displaying an error message and avoiding the crash.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Hello Hosam Aly,

The server was not sending proper reply to Client, so client was crashed.

Thanks.

[Jay Vora (Serpent Consulting Services) (jayvora)]

Marked as duplicate as another bug with same issue with different aspect is posted.
Thanks.

[Hosam Aly (hosamaly)]

Hello Jay. Yes, the client crashed because the server did not send a proper reply, but I still believe that case should be handled, the exception should be caught, and an error message should be presented to the user. This issue will happen every time there is a problem in receiving or parsing the reply, so fixing it in the client once will make up for any future bugs that may appear in the server.

Thank you.