Certain OSI staff visible to affiliates

Bug #408937 reported by Nat Katin-Borland
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
Shane Hathaway

Bug Description

Affiliates seem to be able to see OSI staff who have no community memberships. Having no communities seems to break the security settings.

Email trail:
-----------------------------------------------------------------
Hi Paul,

A sample of the 30 plus users includes:

Juan Aristi

Robert Basch

Julia Gordonna

Tom Penniston

Tamas Varga

They are all listed in GSA. They are not necessarily ‘affiliates’. Rather, they are staff from various parts of our organization.

Nat will enter this into Launch Pad.

Thanks.

-Anthony

--------------------------------------------------------------------------------

From: Paul E
Sent: Tuesday, August 04, 2009 6:37 AM
To: Nathaniel K-B
Cc: Jason L; Thomas M; KARL Admin
Subject: Re: personal log-in access to people

Yes, this should go into LP. We'll need to know a few of the 30 usernames you mention below.

Also, can we take a look in GSA and see if these 30 or so affiliate users exist there? This might show that it was a migration problem and not an ongoing problem. If so, a one-time content cleanup activity would do the trick.

--Paul

On Aug 3, 2009, at 3:46 PM, Nathaniel K-B wrote:

Hi All,

I logged on using my Affiliate Account and explored this issue for a while this afternoon and I think I see why certain users are visible in the People Directory even though we don’t share any communities. It seems that only users without any community memberships are visible. The 30 or so users that Jason identified below all have no communities. Is it possible that this is somehow allowing them to slip through KARL’s security framework? Should this be entered into Launchpad as a bug?

Thanks,

Nat

--------------------------------------------------------------------------------

From: Jason L
Sent: Monday, August 03, 2009 9:39 AM
To: Thomas M; KARL Admin
Subject: RE: personal log-in access to people

I did a little bit of investigation on this… The communities the user moroztom is a member of contain 43 (Media Freedom in Africa) + 13 (GrantTracker BP Implementation) + 1 (Tom Moroz Private) members for a total 58 members that should be visible to the user.

After testing some of the links in the people directory, I got a Forbidden error when loading up the actual profile for the person. It appears there is something out of sync in the indexing. I ran the reindex script on the people directory which brought the number of people visible in the people directory down to 88 (66% correct).

For the remaining 30 people moroztom should not be able to see, the few that I’ve found thus far appear to allow moroztom to view their profile. Since the profile is controlled outside of karl.peopledir, this part appears to be a bug in core KARL.

There are two paths to resolution going forward:

Research the 30 visible members and file a Launchpad bug for core KARL to fix the profile security issue if research proves it exists
As a safety measure, run the reindex script for karl.peopledir every night. I will try to set this up in the next few days.

- Jason

--------------------------------------------------------------------------------

From: Thomas M
Sent: Sunday, August 02, 2009 6:34 PM
To: KARL Admin
Subject: personal log-in access to people

Hi – I was exploring KARL today using my personal log-in (as opposed to OSI) and I found that when I clicked on People, I had access to 166 people, most of whom I do not know and are not sharing a community with 90% of them. Why does this happen? I think this raises some security concerns and we should explore how to make the People feature work properly for affiliate users.

Thanks,

Tom

Changed in karl3:
importance: Undecided → Medium
assignee: nobody → Paul Everitt (paul-agendaless)
Changed in karl3:
assignee: Paul Everitt (paul-agendaless) → Shane Hathaway (shane-hathawaymix)
milestone: none → m26
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Shane, think this is something you could work on later this week?

Revision history for this message
Shane Hathaway (shane-hathawaymix) wrote :

Paul: Yes.

Revision history for this message
Shane Hathaway (shane-hathawaymix) wrote :

The problem was that a number of profiles had no ACL (access control list) associated with them. I wonder if the GSA sync script is failing to trigger the workflow to add ACLs. The following user accounts had no ACL:

bhusejni
cfuersich
dfaherty
evelina
ftemp
ggopez1
gordonna
gugulethu.moyo
hryan
jaristi
jsaldana
kvalasquez
ldesantis
liversen
lrich
lykhman
mariam
mmhoyan
nejebe
oyalcinkaya
rkazandjian
robert.basch
shapoval
tempeurope
tempsfpa
tempsystems
tpenniston
tvarga
tymoshevska
vpizarro
zaure

As it happens, we already have a script called "reapply_profile_security", which solves this problem after it has occurred. I ran the script on karl.soros.org and now all of those profiles have the correct ACLs.

Unfortunately, I don't know what caused the problem in the first place, so I don't know if more profiles might be added without an ACL. I suggest we close this bug for now and reopen it if it happens again.

Changed in karl3:
status: New → Fix Committed
Revision history for this message
Nat Katin-Borland (nborland) wrote :

If I log-in as an affiliate many of the above users are still visible to me in the people section, but if I click on them I get a Forbidden Screen. These users not be visible to me at all. In other words, as an affiliate user if I don't share a community with another user, I should not see any other users in the system.

Revision history for this message
Nat Katin-Borland (nborland) wrote :

Also, Paul, can you get with Ajo and Jason and fill them in on this issue so that they can tweak GSA if necessary? Thanks!

-Nat

Revision history for this message
Nat Katin-Borland (nborland) wrote :

Update: Jason is re-indexing the People Directory which hopefully will fix this problem...

Revision history for this message
Nat Katin-Borland (nborland) wrote :

OK, the re-index worked, so I think we're good.

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.