Right click in the collection panel is extremely slow

[Adam Olsen]

Exaile 0.3

Currently in xlgui.menu.RatedTrackSelectMenu has the following line:

self.connect('enter-notify-event', self.rating_item.on_rating_change)

This causes the rating_item (xlgui.guiutils.MenuRatingWidget) to call widget.get_selected_tracks() (in this case, widget is xlgui.panels.CollectionPanel) every time the mouse is moved into the menu, and once before the popup menu is even displayed.

This causes the popup menu to be very delayed before displaying, and your CPU to spike as you move the mouse around.

I've done some experiments, and even *one* call to panel.get_selected_tracks() prior to displaying the popup menu is too slow when more than a few items are selected.

[Adam Olsen (arolsen)]

I've disabled the automatic updating in r2289 until we can get this fixed.

I see what Steve is trying to do - if all the tracks that are selected have the same rating, the rating menu widget should show that rating. However, this can't be done without a call to panel.get_selected_tracks prior to showing the menu, so either this feature has to be removed, or panel.get_selected_tracks has to be made *much* more efficient.

[reacocard (reacocard)]

retargeting to 0.3.0.2