Playback fails if Exaile was set to auto-resume with an empty playlist

[Steve Dodier-Lazaro]

Exaile 0.3.0bzr trunk, post bugday

If you set exaile to auto resume playback but close it without any song in the playlist, then playback will not work the next time you open it (more accurately there will be no sound).

This is due to the playback restore function that doesn't notice the current track isn't in the playlist.

[reacocard (reacocard)]

I can't verify this in current trunk on either playback engine, is this issue still happening?

[Steve Dodier-Lazaro (sidi)]

The same issue keeps happening under the very same conditions.

[unmacaque (unmacaque)]

Confirming this is still an issue in the latest bzr revision (2396).

Steps to reproduce:
Make sure "Resume playback on start" is enabled and "Open last playlist on startup" is disabled.
1. Play ANY file in any way (library, etc.)
2. While the file is still playing, close Exaile
3. Open Exaile again, play ANY file (does not need to be the same)

It appears that the file is being played but no sound is to be heared. If you slightly move the volume slider, the sound will be there again.

[Steve Dodier-Lazaro (sidi)]

The problem is coming from the fact that the volume of the xl/player is set to 0, then the playback is restored, and then the volume is set to it's actual value. But if the playback can't be restored, we return from the restore_playback function with the volume set to 0, while the GUI's volume slider shows the volume that is meant to be set.

My patch fixes this by directly putting the volume to it's value. If there was a reason while it wasn't working that way before, please add a comment to the source and I'll find another way to fix this.

[reacocard (reacocard)]

The reason we don't set it directly is so that if we have to seek within the file, users dont get a brief bit of music from the beginning of the file when that happens. I've committed a fix for this in r2428 that should have the same effect as your patch.