Backtrace in custom graphs and utf-8 usernames

[Andreas Hasenack]

==> /var/log/landscape/manager.log <==
2009-07-28 10:52:18,309 ERROR [MainThread] Error running message handler for type 'custom-graph-add': <bound method CustomGraphPlugin._handle_custom_graph_add of <landscape.manager.customgraph.CustomGraphPlugin object at 0x7fd7a12d1410>>
Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/landscape/plugin.py", line 73, in dispatch_message
    return handler(message)
  File "/usr/lib/python2.6/dist-packages/landscape/manager/customgraph.py", line 128, in _handle_custom_graph_add
    uid, gid = get_user_info(user)[:2]
  File "/usr/lib/python2.6/dist-packages/landscape/manager/scriptexecution.py", line 38, in get_user_info
    info = pwd.getpwnam(username)
UnicodeEncodeError: 'ascii' codec can't encode characters in position 1-2: ordinal not in range(128)

The username in this case was "fóóbãr". Ok, a fake one, but it illustrates the point.

[Thomas Herve (therve)]

The change for the unicode problem is fairly isolated. There was another problem for reporting missing user error to the server, which should be fixed now.

[Jamu Kakar (jkakar)]

Looks good, +1!

[Kevin McDermott (bigkevmcd)]

One of my suggestions for the "Review guidelines" was going to be "Are there any Unicode holes?" :-)

+1 from me :-)

[Thomas Herve (therve)]

Thanks, merged in r141.

[Andreas Hasenack (ahasenack)]

Ok, no backtrace anymore.

[Andreas Hasenack (ahasenack)]

Confirmed the fix is in the karmic package 1.3.2.4-0ubuntu0.9.10.0~landscape1, qa + 1

[Kevin McDermott (bigkevmcd)]

Works for me!