visited_pages.html: page jumps up when link is clicked

Bug #404998 reported by Siegfried Gevatter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Filesystem
Fix Released
Undecided
Markus Korn

Bug Description

When clicking a link the page will sometimes go back to the top. This is avoided with the following patch:

=== modified file 'src/zeitgeistfs/fselements.py'
--- src/zeitgeistfs/fselements.py 2009-07-25 16:15:11 +0000
+++ src/zeitgeistfs/fselements.py 2009-07-26 19:07:15 +0000
@@ -505,7 +505,7 @@
         content = cls.HEADER %{"year": year, "month": month, "day": day}
         content += "\t<ul>\n"
         for i, (netloc, pages) in enumerate(visited_pages.sorted_iter()):
- content += "\t\t<li><a href='#' onclick=\"toggle('node%i')\">%s</a></li>\n" %(i, netloc)
+ content += "\t\t<li><a href='javascript:;' onclick=\"toggle('node%i')\">%s</a></li>\n" %
             content += "\t\t\t<ul id='node%i' style='display:none'>\n" %i
             for page in pages:
                 content += "\t\t\t\t<li><a href='%s'>%s</a></li>\n" %(page["uri"], page["text"])

Related branches

Markus Korn (thekorn)
Changed in zeitgeist-filesystem:
assignee: nobody → Markus Korn (thekorn)
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.