gives backtrace when opening svn directory with corrupt entries file

Bug #404598 reported by deuxcode
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Bazaar Subversion Plugin
Fix Released
Low
Jelmer Vernooij

Bug Description

It seems that Bazaar halts with the below error when doing bzr add on a dir that contains a .svn folder. The 'lang' folder in the error has a .svn dir. This was the second error I encountered, the first was for another dir, and when I removed the .svn folder and this time bzr add went past that but stopped on another one.

Here is the error:

<snip>
adding [...]
adding cms/modules/News/index.html
bzr: ERROR: subvertpy.SubversionException: ("Error at entry 1 in entries file for 'C:\\www\\xxx\\cms\\modules\\News\\lang':", 145000)
Traceback (most recent call last):
  File "bzrlib\commands.pyo", line 835, in exception_to_return_code
  File "bzrlib\commands.pyo", line 1030, in run_bzr
  File "bzrlib\commands.pyo", line 647, in run_argv_aliases
  File "bzrlib\builtins.pyo", line 647, in run
  File "bzrlib\mutabletree.pyo", line 52, in tree_write_locked
  File "bzrlib\mutabletree.pyo", line 454, in smart_add
  File "bzrlib\bzrdir.pyo", line 836, in open
  File "bzrlib\bzrdir.pyo", line 871, in open_from_transport
  File "bzrlib\bzrdir.pyo", line 2052, in open
  File "C:/Program/Bazaar/plugins\svn\format.py", line 196, in _open
  File "C:/Program/Bazaar/plugins\svn\workingtree.py", line 1002, in __init__
SubversionException: ("Error at entry 1 in entries file for 'C:\\www\\xxx\\cms\\modules\\News\\lang':", 145000)
bzr 1.17 on python 2.5.4 (win32)
arguments: ['bzr', 'add']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program\Bazaar\plugins\bzrtools [1.17]
  launchpad C:\Program\Bazaar\plugins\launchpad [1.17]
  netrc_credential_store C:\Program\Bazaar\plugins\netrc_credential_store [1.17]
  qbzr C:\Program\Bazaar\plugins\qbzr [0.12]
  rebase C:\Program\Bazaar\plugins\rebase [0.5.2]
  svn C:\Program\Bazaar\plugins\svn [0.6.3]
  upload C:\Documents and Settings\Administrat÷r\Application Data\bazaar\2.0\plugins\upload [1.0dev]
*** Bazaar has encountered an internal error.
    Please report a bug at https://bugs.launchpad.net/bzr/+filebug
    including this traceback, and a description of what you
    were doing when the error occurred.

Related branches

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Does "svn add" work for files in that directory?

Revision history for this message
deuxcode (deuxcode) wrote :

Unfortunately I can't say, I don't have svn installed. When I have some time to spare I can always try it if it would help.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Thanks - that should be helpful. Either this is a bug in bzr-svn or a bug in subversion.

From what I can tell this has got to do with a check in the Subversion libraries to make sure that canonical paths are used, but apparently there are a couple of situations in which Subversion itself will (erroneously) write out non-canonical paths and trigger this error.

If it's the add operation that causes the non-canonical path to appear, then this is probably a bug in bzr-svn trying to add a path that is problematic.

Are there any unusual filenames in the directory that you're trying to add, perhaps files with forward slashes or backslashes in their names?

(if this bug is blocking your work and you are not using bzr-svn anywhere you should be able to work around it by using the --no-plugins option when doing the add or removing the bzr-svn plugin).

Martin Pool (mbp)
affects: bzr → bzr-svn
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

It looks like the svn directory there is corrupt, so it's right we can't really do anything. We shouldn't be printing a traceback though but rather a more properly formatted error.

summary: - bzr: ERROR: subvertpy.SubversionException when bzr add encounters a .svn
- dir
+ gives backtrace when opening svn directory with corrupt entries file
Changed in bzr-svn:
status: New → Triaged
importance: Undecided → Low
Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: Triaged → Fix Committed
assignee: nobody → Jelmer Vernooij (jelmer)
milestone: none → 1.0.4
Jelmer Vernooij (jelmer)
Changed in bzr-svn:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.