wxBanker

Wxbanker allows me to rename an account to <null>

Bug #404337 reported by Alan Pope 🍺🐧🐱 🦄
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
wxBanker
Fix Released
High
Unassigned
wxBanker 0.6

Bug Description

It's possible to have an account with no name. I created an account and then clicked 'rename' and it let me rename it to <null> (blank field). This should not be allowed.

Screenshot attached..

Related branches

lp:wxbanker
Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :
Revision history for this message
Michael Rooney (mrooney) wrote :

Hm yes, this shouldn't be possible at all, thanks!

Changed in wxbanker:
importance: Undecided → High
milestone: none → 0.6
status: New → Confirmed
Revision history for this message
Matt Daubney (daubers) wrote :

Commited a fix that throws an exception on this. It won't allow it anymore :)

Changed in wxbanker:
status: Confirmed → Fix Committed
Revision history for this message
Michael Rooney (mrooney) wrote :

Okay, I've fixed this in trunk. Thanks for your branch Matt, I used a similar approach though I think conceptually the checking doesn't belong in the database code so I moved it to the AccountList object which creates accounts and added UI warnings for renaming and creating accounts this way, as well as added two test cases for it. Check out revisions 275 and 276 to see how I did it (`bzr diff -r274..276 lp:wxbanker | less`).

Thanks again, keep the feedback, bug reports and branches coming :)

Michael Rooney (mrooney)
Changed in wxbanker:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.