Test infrastructure for multi-thread load testing

Bug #404223 reported by Sidnei da Silva
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Landscape Client
Fix Released
Medium
Sidnei da Silva

Bug Description

I've did a small refactoring of the LandscapeTest class to move out some of it's functionality to separate unittest.TestCase-based classes, so I can reuse them with FunkLoad.

Another change was the addition of some class-level variables to the FakeRemoteBrokerHelper, so that I can customize them on a subclass.

Additionally, I've added a '--ignore-sigusr1' option to LandscapeService so that it doesn't register the SIGUSR1 handler, since it's not possible to register a signal in multiple threads.

The FunkLoad test I wrote using this is working perfectly, so it would be nice to get those changes in.

Sidnei da Silva (sidnei)
tags: added: review
Sidnei da Silva (sidnei)
Changed in landscape-client:
assignee: nobody → Sidnei da Silva (sidnei)
importance: Undecided → Medium
milestone: none → 1.3.4
status: New → In Progress
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Nice and simple! +1

[1]

While you are at it, would you mind adding a docstring to the new classes?

Revision history for this message
Thomas Herve (therve) wrote :

[1] It looks like MockerTestCase has already make_path and make_dir methods (makeFile and makeDir). Maybe we should use that? I understand it may be a big change, but it seems like a nice cleanup.

+1!

tags: removed: review
Sidnei da Silva (sidnei)
tags: added: review
tags: removed: review
Revision history for this message
Sidnei da Silva (sidnei) wrote :

Addressed Thomas' [1], please do a re-review.

tags: added: review
Revision history for this message
Sidnei da Silva (sidnei) wrote :

 Merge trials-and-tribulations [r=free,therve] [f=404223]

 Refactor some tests to subclass from unittest.TestCase such that it
 can be re-used in benchmarks. Also get rid of noop helper class and
 replace duplicate make_path/make_dir by makeFile/makeDir from
 MockTestCase.

Changed in landscape-client:
status: In Progress → Fix Committed
Revision history for this message
Sidnei da Silva (sidnei) wrote :

Just for the record, Thomas gave me a +1 in person.

tags: removed: review
Jamu Kakar (jkakar)
tags: added: needs-testing
tags: removed: needs-testing
Sidnei da Silva (sidnei)
Changed in landscape-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.