Can't add tracks to playlist from Collection panel

Bug #403945 reported by Johannes Sasongko
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Critical
Exaile Bug Day Events

Bug Description

Test case:
- Add artist 1 to playlist.
- Add artist 2 to playlist.
- Clear playlist.
- Add artist 1 to playlist.

Problem:
- See xlgui/panel/collection @ _find_tracks.
- This function calls load_subtree to load/cache the node subtree. If the subtree is already loaded, it returns.
- However, self.tracks is only set further in load_subtree. If the subtree is already loaded, it is never set and still contains the old value.

Possible solution:
In load_subtree, if the subtree is loaded, set self.tracks before returning. (Not entirely sure that's the right approach; the code here is rather difficult to understand.)

To do:
Document self.tracks. It's unclear what it's supposed to do, yet it's used in several places.

Credits:
Mathias Brodala first reported this bug in #exaile.

Revision history for this message
Brian Parma (bj0) wrote :

Here's a quick fix

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

Thanks. Assigning this to exaile-bugday for review.

Changed in exaile:
assignee: nobody → Exaile Bug Day Events (exaile-bugday)
Changed in exaile:
status: Confirmed → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.