Timeout edge redirect notice logic inverted
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Undecided
|
Guilherme Salgado |
Bug Description
The edge redirection notifications presented on timeouts are now being shown on lpnet, and not on edge. That's a bit useless.
devel r8529 has the below change. Now, my logic is a little rusty, but I think the disjuncts need to be inverted too.
=== modified file 'lib/canonical/
--- lib/canonical/
+++ lib/canonical/
@@ -25,7 +25,10 @@
<script type="text/
var edge_cookie = document.
var edge_host = document.
- if (edge_cookie && edge_host) {
+
+ // Logic has been inverted in the next line to avoid breaking
+ // XHTML compliance of the template due to ampersand usage.
+ if (!(edge_cookie || edge_host)) {
};
Changed in launchpad-foundations: | |
status: | New → Confirmed |
Changed in launchpad-foundations: | |
assignee: | nobody → Guilherme Salgado (salgado) |
tags: | added: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Couldn't you just use a CDATA block (http:// javascript. about.com/ library/ blxhtml. htm) to make it XHTML compliant without messing with the code?