Internet Archive BookReader

link to source code for full-text search

Bug #402797 reported by raj
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Internet Archive BookReader
Confirmed
Undecided
Unassigned
Internet Archive BookReader morebooksinbrowsers

Bug Description

flipbook_search_gb.php depends on code that is not in the gnubook repository. All code needed to get search working on external sites should be checked in. The easiest way to fix this would probably be to update FlipSearchMap and flipbook_search_gb.php to not depend on /petabox/setup.inc or included classes.

Revision history for this message
raj (raj-archive) wrote :

Alternatively, we could just ditch the flipbook-style search and implement it a different way. flipbook search does not give good results, so spending the time to fix the dependency issue might not be time well spent.

Revision history for this message
mangtronix (mang) wrote :

The flipbook-style search is not that great. I think FlipSearchMap just depends on Scandata. Then the other dependency is probably the autoloader.

mangtronix (mang)
Changed in gnubook:
status: New → Confirmed
mangtronix (mang)
Changed in bookreader:
status: New → Confirmed
Revision history for this message
mangtronix (mang) wrote :

We're now using a solr-based full-text search. We should add links to the source code.

summary: - remove flipbook_search_gb.php dependencies
+ link to source code for full-text search
Changed in bookreader:
milestone: none → morebooksinbrowsers
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.