Clean up VPOExport and friends.

Bug #401593 reported by Jeroen T. Vermeulen
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Jeroen T. Vermeulen

Bug Description

Now that the POExport view is gone, it's becoming obvious that the vpoexport module is basically dead weight.

Some things we can clean up with relative ease:
 • VPOExportSet's get_pofile_rows and get_pofile_changed_rows belong in POFile (with dummy implementations in DummyPOFile).
 • A lot of elements in VPOExport are unnecessary: potemplate, template_header, language, variant, translation_file_comment, translation_header, is_translation_header_fuzzy.
 • VPOExport can take msgid_singular and msgid_plural from the POTMsgSet which is fetched anyway.
 • With those gone, there's no need to keep POTMsgSet and its msgids in the join that fetches a POFile's translation rows.

More cleanups will become obvious after this; see bug 401598. The export script creates about 25M VPOExport objects when generating a full Ubuntu language pack, so eliminating just one reference from VPOExport should save at least 200 MB of data traffic on a 64-bit server (plus dict overhead).

description: updated
description: updated
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Weekend branch.

Changed in rosetta:
assignee: nobody → Jeroen T. Vermeulen (jtv)
importance: Undecided → Low
milestone: none → 2.2.9
status: New → In Progress
Revision history for this message
Matthew Revell (matthew.revell) wrote :

Retargeting to 3.0, which is the new name for 2.2.9. Haven't renamed the milestone as the 3.0 milestone is in a different series.

Changed in rosetta:
milestone: 2.2.9 → 3.0
Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Fixed in devel 9006

Changed in rosetta:
status: In Progress → Fix Committed
Changed in rosetta:
milestone: 3.0 → 2.2.8
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.