Compatibility with different Firefox versions (.desktop file)

Bug #398448 reported by Siegfried Gevatter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zeitgeist Framework
Invalid
Undecided
Unassigned

Bug Description

The firefox datasource has "/usr/share/applications/firefox.desktop" hardcoded, but that assumption is not always valid (eg., the user may have a firefox-3.5.desktop file).

Changed in zeitgeist:
importance: Undecided → Low
summary: - Compatibility with different Firefox versions
+ Compatibility with different Firefox versions (.desktop file)
Revision history for this message
Markus Korn (thekorn) wrote :

Yes, you are right, the current code is not optimal, and I thought about this at the time when I wrote the code. the problem here is a more general one: a user can have many different .desktop files on his system describing the very same application (like one in /usr/share/applications and one in ~/.local/share/applications), but the zeitgeist engine will always treat them as different apps. So I decided to hardcode the same .desktop file in the query for the last inserted data and the item dict in _get_items_uncached().
The best solution for this would be if we had an Dbus API which returns the .desktop file for an application, like
GetDesktopfileForApplication("firefox") -> /usr/share/applications/firefox.desktop
If this method raises a "NotFoundError" (or similar) the FF dataprovider should try to find the desktop file related to the profile it is watching

Seif Lotfy (seif)
Changed in zeitgeist:
status: New → Invalid
Seif Lotfy (seif)
Changed in zeitgeist:
importance: Low → Undecided
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.