Allow specifying Team requirements

Bug #397868 reported by dobey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tarmac
Fix Released
Medium
dobey

Bug Description

Tarmac should have a per-branch configuration option to specify a Team or Teams which an Author must be a member of in order for their code to land in the Target. For Canonical related projects which require the Contributor Agreement to be signed, this would allow us to have a team which includes all the users who have signed the agreement, which we could check against automatically.

Related branches

Revision history for this message
Paul Hummer (rockstar) wrote :

Launchpad is going to support this soon.

Changed in tarmac:
importance: Undecided → Low
status: New → Triaged
Revision history for this message
Paul Hummer (rockstar) wrote :

So, I think that isPersonTrustedReviewer is probably what we want here. Maybe this is now a dupe of bug #426950. Rodney, what do you think?

Changed in tarmac:
milestone: none → tarmac-0.4
Revision history for this message
dobey (dobey) wrote :

I'm not sure about that. Using isPersonTrustedReviewer probably can solve part of the issue. But the lp:~contributor-agreement-canonical team is a special case still. It's not a member of the teams which have direct access to the branches in question, nor should it be. It should itself not be a member of other teams. But it should be usable as a reference in an automatic manner, for some things.

This is not so much about reviews, but rather who is allowed to contribute code. But it should be easy to write a plug-in to handle this now. I think I'll write one real quick. :)

Revision history for this message
dobey (dobey) wrote :

This will depend on bug #397853 being fixed though.

Paul Hummer (rockstar)
Changed in tarmac:
milestone: tarmac-0.4 → none
dobey (dobey)
Changed in tarmac:
assignee: nobody → Rodney Dawes (dobey)
importance: Low → Medium
status: Triaged → In Progress
Paul Hummer (rockstar)
Changed in tarmac:
status: In Progress → Fix Committed
Paul Hummer (rockstar)
Changed in tarmac:
milestone: none → tarmac-0.5
Paul Hummer (rockstar)
Changed in tarmac:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.