TODO: Refactoring zeitgieist.dbusutils
Bug #397432 reported by
Markus Korn
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Zeitgeist Framework |
Fix Released
|
High
|
Markus Korn | ||
Bug Description
dbusutils has a few useful functions for people who wants to access the public DBus API of zeitgeist. This methods are:
- get_engine_
- plainify_dict()
- dictify_data()
All other methods/constants don't are not useful for the 'public' and should be prefixed with a underscore. In my opinion it also makes sense to merge all get_*() into one get_interface() method.
None of this method should ever call sys.exit(), because this will cause clients to also exit. But clients should be able to react on this errors, like showing messages to the user etc. Insead of calling sys.exit() exceptions should be raised.
Related branches
lp:~thekorn/zeitgeist/fix.dbusutils.397432
- Siegfried Gevatter: Approve
- Natan Yellin: Pending (code singleton) requested
- Zeitgeist Framework Team: Pending requested
- Diff: None lines
| Changed in zeitgeist: | |
| importance: | Undecided → High |
| milestone: | none → 0.2 |
| summary: |
- TODO: Refoctoring zeitgieist.dbusutils + TODO: Refactoring zeitgieist.dbusutils |
Revision history for this message
| Markus Korn (thekorn) wrote | #1 |
| Changed in zeitgeist: | |
| assignee: | nobody → Markus Korn (thekorn) |
| status: | New → In Progress |
| Changed in zeitgeist: | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
started to work on it in the attached branch