double clicking on file in WorkingTree view always executes the "default" option

[John A Meinel]

I'm not sure the specific purpose of the WorkingTree view, as at the moment it doesn't support right clicks, and only seems a launching point to open up a real explorer/nautilus or run Browse.

You can double click a file, but on my system, double-clicking a .py file *executes* it, when I want to edit it in my text editor. At least when I browse to the file using Explorer, I can "right-click/Edit in Vim".

Similarly, I can browse in Explorer, select multiple files, and edit them in a single Vim session. While the WT view does not support multiple selection.

[Ian Clatworthy (ian-clatworthy)]

It's very limited in scope right now. The intention is to reuse a smart widget being developed as part of QBzr. As of time of writing though, that widget isn't in a released version of the QBzr trunk.

The double-click action is explicitly "open". I feel that's the best default because it does the right thing for more types of files, e.g. when I what to browse the latest doc by double-clicking on doc/index.html in bzr.dev. To edit, single-click and select Edit.

[Ian Clatworthy (ian-clatworthy)]

It's also a deliberate decision *not* to try to do everything the platform file managers can. I want Bazaar Explorer to provide the core functionality and defer to them for the rest (hence the Manage button). In theory, we have TortoiseBzr, NautilusBzr, etc. that fill the gap for users wanting a file-centric tool. The focus of BzrExplorer, at least initially, is branch management, change management, workflow and collaboration.

[Robin Munn (rmunn)]

Ian Clatworthy wrote:

>The double-click action is explicitly "open". [...] To edit, single-click and select Edit.

For me, at least, this breaks the Principle of Least Surprise. I also expected the double-click default to be "Edit"; in my case, this meant my .py files were opening with gedit when I double-clicked, but gvim (my default editor in ~/.bazaar/bazaar.conf) when I clicked the "Edit" button. I almost reported this as a new bug before realizing it was really a case of this bug.

Most of the time, if I'm looking at my branch in Bazaar Explorer, it's because I want to do something with it -- edit my files, run diffs, merge branches. Double-clicking on doc/index.html to view it in Firefox is something I would usually do in Nautilus, not Bazaar Explorer; when I'm looking at Bazaar Explorer, I'm probably thinking of editing files when I double-click them.

In other words: This Bug Affects Me Too (TM). :-)

[Ian Clatworthy (ian-clatworthy)]

Whether double-click launches 'open' or 'edit' is now a preference