Cannot recategorize a video to TV show through manual entry

[Sudesh]

Was unable to recategorize video to TV show through manual entry.

Steps to reproduce:

1.Launch Moovida 1.0.4
2.Goto Unclassified videos->Press on video recategorization->TV episode
3.Press refine search
4.EnterTitle, season number,episode number
5.No results found screen comes up,press continue.

Expected Result : Video should get recateogorized.

Current Result : Again takes user to video recategorization screen.

Here is stack trace:

Traceback (most recent call last):
  File "c:\program files\moovida\elisa-plugins\elisa\plugins\poblesec\history.py", line 80, in append_controller

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\pigment\pigment_frontend.py", line 168, in create_controller

  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 191, in addCallback

  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 182, in addCallbacks

--- <exception caught here> ---
  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 317, in _runCallbacks

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\pigment\pigment_frontend.py", line 225, in _set_frontend

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\database\video_categorizer.py", line 1237, in set_frontend

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\database\video_categorizer.py", line 1553, in _get_message

exceptions.TypeError: format requires a mapping

WARN MainThread default Jul 06 17:30:23 Entering controller with path /poblesec/database/recategorize/confirm/tvepisode/manual failed. Full failure log at c:\docume~1\sudesh~1.cyb\locals~1\temp\elisa_wp71bt.txt (elisa\plugins\poblesec\history.py:75)
Unhandled error in Deferred:
Traceback (most recent call last):
  File "c:\program files\moovida\elisa-plugins\elisa\plugins\poblesec\history.py", line 80, in append_controller

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\pigment\pigment_frontend.py", line 168, in create_controller

  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 191, in addCallback

  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 182, in addCallbacks

--- <exception caught here> ---
  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 317, in _runCallbacks

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\pigment\pigment_frontend.py", line 225, in _set_frontend

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\database\video_categorizer.py", line 1237, in set_frontend

  File "C:\src\1.0.4.1\elisa-plugins\elisa\plugins\database\video_categorizer.py", line 1553, in _get_message

exceptions.TypeError: format requires a mapping

[Olivier Tilloy (osomon)]

Indeed the overridden implementation of the _get_message method in the ConfirmToManualTVEpisodeController is wrong, the message formatting should take in a dictionary, not a tuple.

[Olivier Tilloy (osomon)]

Note that there is a related problem in elisa-plugins/elisa/plugins/database/tvshows_controllers.py, lines 173-174. The dictionary key "number" should be "season".

[Olivier Tilloy (osomon)]

And here is the corresponding traceback:

Unhandled error in Deferred:
Traceback (most recent call last):
  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\base.py", line 533, in runUntilCurrent
  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 239, in callback
  File "build/bdist.linux-i686/egg/elisa/core/utils/cancellable_defer.py", line 132, in _startRunCallbacks
  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 304, in _startRunCallbacks
--- <exception caught here> ---
  File "C:\Program Files\Moovida\deps\lib\site-packages\twisted\internet\defer.py", line 317, in _runCallbacks
  File "build/bdist.linux-i686/egg/elisa/plugins/database/tvshows_controllers.py", line 174, in got_show
exceptions.KeyError: u'season'