Can't browse through albums which name begins and ends by a " in the collection sidebar

[Steve Dodier-Lazaro]

If the title of an album (probably happens with artists too) is for instance "Foo" instead of just Foo, then clicking on it won't expand it to show the current tracks, the arrow will disappear and the user won't be able to see the songs in the album.

In the attached screenshot, you can see on the top left that the albums with an " in the beginning of their names have lost their arrow after I've clicked on it.

[reacocard (reacocard)]

should be fixed now.

[Steve Dodier-Lazaro (sidi)]

I didn't notice any improvement. There is no debug output at all, even with --debug, but I still cant browse through albums beginning with " in the collection panel.

[Steve Dodier-Lazaro (sidi)]

I actually noticed that it happens only if the name begins but also ends with ". If it only begins with " it seems to work normally.

[reacocard (reacocard)]

fixed in r2353

[Steve Dodier-Lazaro (sidi)]

Broken again. And funnily, the fix is still in place. Was a similar issue introduced in another code path ?

[Steve Dodier-Lazaro (sidi)]

The bug also occurs with albums containing '\'.

[reacocard (reacocard)]

retargeting to 0.3.0.2

[Steve Dodier-Lazaro (sidi)]

Tracks containing two " in their name also can't be added into libraries. I'm feeling about putting this bug critical :]

[Gabriel Speckhahn (gabspeck)]

In fact, songs with quotes covering part of their title cannot be added to playlists.

Examples:

The Jam - "A" Bomb in Wardour Street - BAD
Sly & The Family Stone - Africa Talks to You "The Asphalt Jungle" - BAD
David Bowie - "Heroes" - GOOD
Blondie - One Way or Another - GOOD

[Bburst (bbaiyfb)]

What seems to make exaile bug is the combination of quotes and spaces.
For instance, <<Belleville>>, <<Belle ville>> and <<"Belleville">> work but <<"Belle ville">> fails.

I *think* the problem lies in xl/trackdb.py, in TrackSearch.tokenize_query.
At some point, it does <<tokens = search.split(" ")>>. But if the space appears inside the quotes, it should not split.

I provide a patch but I'm quite unsure that it is correct. However, it does solve my <<"Belle ville">> problem.

[reacocard (reacocard)]

Attached is a patch that I hope will resolve these issues. It also makes the search code a lot shorter, and hopefully easier to understand. Please test and report results.

[Steve Dodier-Lazaro (sidi)]

The patch doesn't apply in the 0.3.0.x branch.

[reacocard (reacocard)]

Sorry, should have mentioned the patch is for trunk only. The same logic placed into 0.3.0.x doesn't quite work, probably due to some sort of subtle difference in the search system.

[reacocard (reacocard)]

Figured it out, here's one for 0.3.0.x.

[reacocard (reacocard)]

got confirmation from Steve that the patch works, committed 0.3.0.x/2449, trunk/2572.