Solaris 32 bit build broken in revision 1085

[Lee Bieber]

http://gorf.tangent.org/hudson/job/Drizzle-norbye-32bit.org/12/console

mkdir plugin/myisam/.libs
 CC -DHAVE_CONFIG_H -I. -I. -I./gnulib -I./gnulib -I/opt/drizzle/include -I/opt/google/include -I/home/hudson/build/libdrizzle/include -I/home/hudson/build/gearman/include -I/home/hudson/build/libmemcached/include +w +w2 -xport64 -errtags=yes -erroff=attrskipunsup,doubunder,reftotemp,inllargeuse,truncwarn1,signextwarn,inllargeint -errwarn=%all -xO3 -xlibmil -xdepend -xbuiltin -lmopt -xlang=c99 -g -mt -compat=5 -library=stlport4 -template=no%extdef -c plugin/myisam/ha_myisam.cc -KPIC -DPIC -o plugin/myisam/.libs/plugin_libmyisam_plugin_la-ha_myisam.o
"plugin/myisam/ha_myisam.cc", line 1505: Error, truncwarn: Conversion of 64 bit type value to "unsigned long" causes truncation.
1 Error(s) detected.
gmake[2]: *** [plugin/myisam/plugin_libmyisam_plugin_la-ha_myisam.lo] Error 1
gmake[2]: Leaving directory `http://gorf.tangent.org/hudson/job/Drizzle-norbye-32bit.org/ws/'
gmake[1]: *** [all-recursive] Error 1
gmake[1]: Leaving directory `http://gorf.tangent.org/hudson/job/Drizzle-norbye-32bit.org/ws/'
gmake: *** [all] Error 2

[Lee Bieber (kalebral-deactivatedaccount)]

reassigning per message from Monty

[Trond Norbye (trond-norbye)]

If we look at the datatypes here we have:

bitset &= uint64_t

bitset contains the following constructor: bitset(unsigned long val); so we create a temporary bitset object and use the &= operator. The problem is that in 32 bit builds unsigned long is 32 bit, so we don't have a constructor for a uint64_t.

I would suggest that we cast the uint64_t to a size_t, because that would strip off the upper 32 bits on 32 bit builds, but leave the value intact on 64 bit builds. I don't think this is a clean solution, but this is the myisam plugin ;-)

[Trond Norbye (trond-norbye)]

Ah... I just looked in the linked branch and noticed that the problem was solved :-)