activateCollapsibles() doesn't play nice with YUI effects; needs to be reimplemented using YUI

Bug #394795 reported by Graham Binns
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Graham Binns

Bug Description

At the moment we use a custom activateCollapsibles() function to turn fieldsets with the class "collapsible collapsed" into toggle-able collapsed areas on a page. This function is old and crufty, as mars observed:

 <mars> gmb, I would avoid that function altogether. It's nasty. And incorrect in subtle ways.

Moreover, when used inside an element that gets hidden and shown using Y.lazr.effects.slide_(in|out), nasty things happen (see attached screenshot).

To get around this, we should re-implement activateCollapsibles() using YUI. The functionality should stay the same, except that it can use the slide_in and slide_out animations to make things a bit more pleasing to the eye.

Note that it may be better to write a replacement function to be used in cases where the existing functionality is inadequate before transitioning all collapsibles to use the new code.

Revision history for this message
Graham Binns (gmb) wrote :
Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r8818.

Changed in launchpad-foundations:
status: In Progress → Fix Committed
Graham Binns (gmb)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.