IDistroSeries.getQueueItems deprecated by IPackageUploadSet.getPackageUploads
Bug #394645 reported by
Julian Edwards
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
High
|
Jeroen T. Vermeulen |
Bug Description
As part of the fix for bug 123020, getQueueItems was deprecated and replaced with getPackageUploads, which is re-written in Storm syntax.
However, it is not a complete implementation yet, this bug exists to remind developers to finish it off.
Related branches
lp:~jtv/launchpad/bug-394645
- Robert Collins (community): Approve
-
Diff: 42 lines (+7/-6)2 files modifiedlib/lp/registry/interfaces/distroseries.py (+5/-4)
lib/lp/soyuz/interfaces/queue.py (+2/-2)
lp:~jtv/launchpad/pre-394645
- Jeroen T. Vermeulen (community): Approve
-
Diff: 7323 lines (+2868/-2803)10 files modifiedlib/lp/archiveuploader/tests/nascentupload.txt (+482/-462)
lib/lp/archiveuploader/tests/test_ppauploadprocessor.py (+1/-1)
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+15/-17)
lib/lp/soyuz/doc/distroseriesqueue-ddtp-tarball.txt (+186/-183)
lib/lp/soyuz/doc/distroseriesqueue-dist-upgrader.txt (+239/-228)
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+365/-361)
lib/lp/soyuz/doc/distroseriesqueue.txt (+589/-579)
lib/lp/soyuz/doc/soyuz-set-of-uploads.txt (+495/-482)
lib/lp/soyuz/doc/soyuz-upload.txt (+495/-489)
lib/lp/soyuz/scripts/processaccepted.py (+1/-1)
lp:~jtv/launchpad/post-394645
- Gavin Panella (community): Approve
-
Diff: 1598 lines (+214/-600)20 files modifiedlib/lp/archiveuploader/tests/nascentupload-announcements.txt (+1/-1)
lib/lp/archiveuploader/tests/nascentupload.txt (+4/-4)
lib/lp/archiveuploader/tests/test_ppauploadprocessor.py (+41/-41)
lib/lp/archiveuploader/tests/test_uploadprocessor.py (+44/-42)
lib/lp/registry/interfaces/distroseries.py (+3/-2)
lib/lp/registry/model/distroseries.py (+1/-152)
lib/lp/soyuz/browser/queue.py (+6/-11)
lib/lp/soyuz/doc/distroseriesqueue-ddtp-tarball.txt (+2/-2)
lib/lp/soyuz/doc/distroseriesqueue-dist-upgrader.txt (+1/-1)
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+7/-7)
lib/lp/soyuz/doc/distroseriesqueue.txt (+35/-188)
lib/lp/soyuz/doc/soyuz-set-of-uploads.txt (+4/-3)
lib/lp/soyuz/doc/soyuz-upload.txt (+3/-51)
lib/lp/soyuz/interfaces/queue.py (+2/-26)
lib/lp/soyuz/model/queue.py (+0/-10)
lib/lp/soyuz/scripts/initialize_distroseries.py (+10/-8)
lib/lp/soyuz/scripts/processaccepted.py (+2/-2)
lib/lp/soyuz/scripts/queue.py (+4/-6)
lib/lp/soyuz/scripts/tests/test_queue.py (+41/-40)
lib/lp/soyuz/tests/test_packageupload.py (+3/-3)
tags: |
added: tech-debt removed: cleanup |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Jeroen T. Vermeulen (jtv) |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
Changed in launchpad: | |
status: | Fix Released → In Progress |
tags: |
added: qa-untestable removed: qa-needstesting |
tags: |
added: qa-ok removed: qa-needstesting |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
getPackageUploa ds/getAll are now pretty much on par with getQueueItems (apart from still ignoring the archive parameter). That means we can move the queue.py script and the +queue page over to use the new code, which means they will also pick up PackageCopyJob uploads.