[PATCH] gksu absolute icon path

Bug #3941 reported by Thierry Moisan
6
Affects Status Importance Assigned to Milestone
GKSu
Incomplete
Undecided
Unassigned
gksu (Ubuntu)
Invalid
Wishlist
Ubuntu GNOME

Bug Description

following https://wiki.ubuntu.com/UniverseDesktopFileAbsolutePath
here's the patch to fix this problem in gksu package.

Revision history for this message
Thierry Moisan (thierryn) wrote : proposed patch

I made the changes for dapper since this is not critical enough to go in breezy-update.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for your bug. When reviewing the desktop files could you also fix the other issues they have?

$ desktop-file-validate /usr/share/applications/gksu.desktop
/usr/share/applications/gksu.desktop: error: required key "Encoding" not found
/usr/share/applications/gksu.desktop: warning: non-standard key "MultipleArgs" lacks the "X-" prefix
/usr/share/applications/gksu.desktop: error: value of key "Categories" is a list of strings and must end with a semicolon

This wiki list is a good idea but should be restricted to one line of the desktop file. The bug should also go upstream, we don't want to create packaging diff for this, better to get the fix for free from upstream.

Changed in gksu:
assignee: nobody → lopez-desktop
Changed in gksu:
assignee: lopez-desktop → gnome
Revision history for this message
Thierry Moisan (thierryn) wrote : unified patch

Fixing the .desktop files like said in the comment #2.

Revision history for this message
Thierry Moisan (thierryn) wrote : better patch

I changed the last patch so that we don't force the file extension.

Revision history for this message
Daniel Holbach (dholbach) wrote :

Michael, you like the patch? :)

Michael Vogt (mvo)
Changed in gksu:
status: New → Rejected
Revision history for this message
Alberto Salvia Novella (es20490446e) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. We are sorry that we do not always have the capacity to look at all reported bugs in a timely manner. There have been many changes in Ubuntu since that time you reported the bug and your problem may have been fixed with some of the updates. It would help us a lot if you could test it on a currently supported Ubuntu version. When you test it and it is still an issue, kindly upload the updated logs by running apport-collect <bug #> and any other logs that are relevant for this particular issue.

Changed in gksu:
status: New → Incomplete
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.