Display revno, not just version number

Bug #392668 reported by Matt Nordhoff
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
loggerhead
Fix Released
Wishlist
Cruz Bishop

Bug Description

Loggerhead now displays its version number in pages (see bug #370155), but it would be useful if it displayed the revno as well, if it's running from a branch.

bzrlib's revno might be useful too.

Code for this could probably be stolen from bzr's version command.

I've had a few ideas for how exactly to display it:

> My first idea was to make the line at the bottom something like:
>
> Loggerhead <abbr title="r123 (2009-06-25) revid:xxx">1.10</abbr> ...
>
> It might make sense to do it like edge.launchpad does, something like
> one of these:
>
> Loggerhead 1.10 (r123) ...
> Loggerhead 1.10 (<abbr title="$revid (2009-06-25)">r123</abbr>)
> Loggerhead 1.10 (<abbr title="2009-06-25 ($revid)">r123</abbr>)

Related branches

Revision history for this message
Martin Albisetti (beuno) wrote : Re: [Bug 392668] [NEW] Display revno, not just version number

Bonus points if the revno links to the loggerhead revision on launchpad ;)

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

The revision may not be on lp:loggerhead, and it'd be rude for Loggerhead instances everywhere to probe Launchpad to check.

AIUI, Launchpad runs a custom branch of Loggerhead. I know I do.

In my case, my Loggerhead install is at ~/loggerhead. Its parent is /srv/bzr/loggerhead/cheezum, which has its public branch set to http://bzr.mattnordhoff.com/bzr/loggerhead/cheezum/, which happens to be viewable from http://bzr.mattnordhoff.com/loggerhead/loggerhead/cheezum/changes and registered on Launchpad as lp:~mnordhoff/loggerhead/cheezum. It's not really possible to make Loggerhead automatically figure it all out and Do The Right Thing. I guess a configuration option or two could be added, but that would be a lot of trouble for a little link at the bottom of the page... *I* wouldn't mind, but I doubt most users would agree.

It would probably be best to make bzrlib equally configurable, doubling the complication.

Revision history for this message
Robert Collins (lifeless) wrote :

On Fri, 2009-06-26 at 19:19 +0000, Martin Albisetti wrote:
> Bonus points if the revno links to the loggerhead revision on launchpad
> ;)

Why would it? If its running from a branch, link to its own
branch :) :) :)

-Rob

Revision history for this message
Matt Nordhoff (mnordhoff) wrote :

Robert Collins wrote:
> On Fri, 2009-06-26 at 19:19 +0000, Martin Albisetti wrote:
>> Bonus points if the revno links to the loggerhead revision on launchpad
>> ;)
>
> Why would it? If its running from a branch, link to its own
> branch :) :) :)
>
> -Rob

How would it know what URL to give the branch? Some special /+self URL?
The branch might also be viewable from some other URL, causing duplication.
--

Changed in loggerhead:
status: Triaged → In Progress
assignee: nobody → Cruz Bishop (cruzjbishop)
Changed in loggerhead:
assignee: Cruz Bishop (cruzjbishop) → nobody
Revision history for this message
Cruz Bishop (cruzjbishop) wrote :

Opened a merge request :)

Changed in loggerhead:
assignee: nobody → Cruz Bishop (cruzjbishop)
status: In Progress → Fix Committed
Changed in loggerhead:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.