unmount menu option should have an icon

[Maarten Bosmans]

When a volume is mounted, there is an icon next to the volume in Nautilus, that's great.

The volume is also displayed on the desktop, with an option to unmount in the right-click menu.
This menu option should have the same eject icon for consistency and easy discoverability.

[Vish (vish)]

Good catch.Seems to be a papercut, Could you provide screenshots to be clearer for all.

At present there is no icon in the menu. AFAIK adding the menu icon might not be easy, might need to discuss this upstream.

[Maarten Bosmans (mkbosmans)]

> AFAIK adding the menu icon might not be easy, might need to discuss this upstream.

What can there possibly be difficult in adding an icon for this menu item?
Just asking.

[Sebastien Bacher (seb128)]

The design team has been fighting adding an icon for every single menu item not sure that one makes sense

[Maarten Bosmans (mkbosmans)]

> The design team has been fighting adding an icon for every single menu item
> not sure that one makes sense

OK, think about this: what would be one of the most likely things a user wants to do upon right clicking a mounted volume? It is quit a large list of menu items (OK, I'm on a 10" netbook) and an unmount icon really helps scanning the list, especially because you can recognize it from the places bar in Nautilus.

An icon for unmount makes a lot more sense IMHO than icons for cut/copy/paste. I'd go even further and say that the unmount entry should be at the top, right below open/browse folder.

[Vish (vish)]

> What can there possibly be difficult in adding an icon for this menu item?Just asking
See Sabestien's comment.
Since they feel that there are more bigger problems, they are not much interested in this ATM.

But since you seem to be interested and know how to fix this, Pls provide us with the patch , it would be gladly welcome by the community.

Also ,pull up your sleeves and Dig into any of the other papercuts you can fix. :)

[Rich Jones (richwjones)]

Unmount should have an icon!

[Vish (vish)]

The icon label is:
/xxx/xx/xxx/actions/media-eject

[Marcus Carlson (0-launchpad-mejlamej-nu)]

I might take a look at it tonight.

[Marcus Carlson (0-launchpad-mejlamej-nu)]

Should both "Unmount Volume" and "Eject Volume" have the same icon (media-eject)?
Needs review.

[Maarten Bosmans (mkbosmans)]

Two options seems a much. For an USB medium eject is not applicable and for a CD drive unmount without eject seems a rather obscure usecase.

See also the quite log discussion on
https://bugs.launchpad.net/hundredpapercuts/+bug/28835

[Vish (vish)]

> Should both "Unmount Volume" and "Eject Volume" have the same icon (media-eject)? Needs review.

The ideal way would be to *not* have the unmount icon for CD/DVD ,[Only eject has the icon]
While the drives have an unmount icon.[This includes mounted iso which have only an unmount option]

@ *David Siegel* , your thoughts?

[Vish (vish)]

This behavior seems to have been changed!
https://bugs.launchpad.net/hundredpapercuts/+bug/28835/comments/62
Seems all unmount menu items are re-labeled as "Eject" , except for the partitions, which uses unmount.

Someone needs to confirm with upstream what they have done.

[Vish (vish)]

@Marcus Carlson:
Kindly update the patch.

[Matthew Paul Thomas (mpt)]

None of the items in this menu represent dynamic objects (files, bookmarks, folders etc), so none should have icons by default (i.e. with "Show icons in menus" turned off). I have no objection to adding the icon for people who have "Show icons in menus" turned on.

[Vish (vish)]

As per comment #15 , since a default install will have only essential icons , this is not a papercut.

[Pedro Villavicencio (pedro)]

closing the nautilus task as well since those menu icons were removed last cycle. makes no sense to add just one now, thanks.