Teams still getting karma

[Stuart Bishop]

https://launchpad.net/people/rosetta-admins/+karma shows that teams are
still able to get karma. Either the add karma api exposed by IPerson is
broken, or bits of Rosetta are not using it.

 affects /products/launchpad

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

[Guilherme Salgado (salgado)]

The IPerson.assignKarma() method is broken. Actually, I think the problem is that IPerson.is_valid_person (used inside assignKarma to ensure we don't assign karma to teams or inactive accounts, as the comment says) is misleading as it will also be True for teams.

[Stuart Bishop (stub)]

Guilherme Salgado wrote:
> The IPerson.assignKarma() method is broken. Actually, I think the problem is that IPerson.is_valid_person (used inside assignKarma to ensure we don't assign karma to teams or inactive accounts, as the comment says) is misleading as it will also be True for teams.

IPerson.is_valid_person should be false for teams if I recall.

--
Stuart Bishop <email address hidden> http://www.canonical.com/
Canonical Ltd. http://www.ubuntu.com/

[Guilherme Salgado (salgado)]

No, IPerson.is_valid_person is True for teams because it queries ValidPersonOrTeamCache. This should be fixed together with a test.

[Stuart Bishop (stub)]

I'll need to trash the karma associated with teams manually after rollout.