GTG

Color picker should be populated with current color

Bug #391314 reported by Zach Shepherd
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GTG
Fix Released
Medium
Unassigned

Bug Description

When the color picker is opened for a task that already has a color assigned, the current color should show up as "picked".

Revision history for this message
Zach Shepherd (eightball1989) wrote :

The attached diff/patch seems to fix this problem for me, although it does ignore the "notag_only" variable (I couldn't figure out quite what this did) as well as the case where the number of selected tags is anything other than 1 (I wasn't sure how to select multiple tags or what the appropriate behavior would be (should it just take the color of the first selected tag?).

This was my first look at the gtg code, so feedback would be appreciated.

Revision history for this message
Zach Shepherd (eightball1989) wrote :

Looks like I didn't test well enough. That appears to break when a tag doesn't have a color set. I'll give it another shot when I get a chance.

Revision history for this message
Zach Shepherd (eightball1989) wrote :

This tests to make sure that the current color is not "None".

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

thanks Zach, I will revew it ASAP. For the record, "notag_only" is the case where you select to display only tasks that don't have a tag. (second line in the sidebar).

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

This has been commited, thanks for the patch :-)

Changed in gtg:
assignee: nobody → Lionel Dricot (ploum)
importance: Undecided → Medium
milestone: none → 0.1.2
status: New → Fix Committed
Changed in gtg:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.