Incorrect urgency for NetworkManager

[moomex]

Disconnecting from a network usually has a high "urgency" level. However, notify-osd sometimes shows "normal" urgency when disconnecting from a wired network and "low" urgency when connection is established.

But there is a problem with this urgency levels:
When waking up from suspend, the notification appears saying "Disconnected" at exact the time when wireless networking has been connected again. But the notification for "Wlan Connected" appears a lot of time later, because it has low urgency level.

I suggest to make the networking notifications update-able, so that the right status is posted at the right time.
When the connection is established again the "disconnected" notification should update and write "connected" at exact this time.

[Murat Gunes (mgunes)]

Thanks for reporting. The behavior you've noted is by design [1]; the urgency level should be "urgent" only in the cases where the disconnection leaves you with no active network connections.

As for connecting to a network, "low" is probably justified, since the event is initiated by the user, and thus predictable, as opposed to a disconnection, which may happen without the user's initiative.

[1] https://wiki.ubuntu.com/NotifyOSD#network-manager

[Stefan Hammer (j-4-deactivatedaccount)]

But there is a problem with this urgency levels:
When waking up from suspend, the notification appears saying "Disconnected" at exact the time when wireless networking has been connected again. But the notification for "Wlan Connected" appears a lot of time later, because it has low urgency level.

I suggest to make the networking notifications update-able, so that the right status is posted at the right time.
When the connection is established again the "disconnected" notification should update and write "connected" at exact this time.

Thanks,
Jango

[Mirco Müller (macslow)]

This is actually an issue of network-manager and not notify-osd itself. Reassigned.

[Mathieu Trudel-Lapierre (cyphermox)]

Fair enough. Is there a way to track notifications sent and update the previous disconnected one, or cancel it to show the connected within a period of time?

Marking Triaged. I think it deserves some improvement, but generally it's still doing the job, and the actual notification urgency levels appear to me as they are fine and definitely make sense for the type and likely cause of the event.

I'll get around to it at some point, but if anyone has time to propose a patch that tries to keep track of notifications and back out of one if it was sent out within a specific period of time preceeding the new notification (something like within the delay for a notif. to fade out maybe?), I'll gladly review it ;)