"Recent activities" listing on the overview page incorrect

[Anthony]

Bug Reported by Chipp Winston:

Something a little funky is happening with wiki page listings on the "recent activities" listing on the overview page of a community. The list should function as an itemization of all edits and adds to the community. But today, when somebody edited one of the wiki pages that I created many months ago, my name showed up in the recent activity list as having done something to the page [which I didn’t do]. The page should show up as having been edited, but the author should be the person who edited the wiki page, not the person who created it [me in this case]

[Paul Everitt (paul-agendaless)]

Hi Anthony (and Chipp). This was something that came up with Nat. It wasn't clear to us at the time what should be the behavior...should editing something make you the creator (what shows up in the byline)? Or, should we add a new field to all the content and keep track of a separate piece of information for "last modifier"?

I checked at the time (and confirmed now) that editing something in KARL2 makes the new person the "creator", overwriting any mention of the original author. We can put in that behavior easily, but I think we might want to put this through the feature process and rethink how that is done.

[Chris Rossi (chris-archimedeanco)]

Deferring. To quote Paul:

"I suppose to follow the process correctly, we need to put this into the feature backlog, likely as something for the nearest possible release (3.2, end of July).

"For this, we simply need approval from whatever is the right way that stuff gets commissioned. I suppose since this is something that was there (but done stupidly) in KARL2, and missing in KARL3, it should get a high precedence.

--Paul"

[Paul Everitt (paul-agendaless)]

Moving from Chris to Shane, as Chris is on migration.

[Shane Hathaway (shane-hathawaymix)]

Done in revision 3520. Added a modified_by attribute, which now gets shown in the community recent activity list. Note that this information has not been stored until now, so the change will be visible only with new edits.

[Paul Everitt (paul-agendaless)]

Re-opening. In a fresh sandbox, after doing bin/start_over --yes, I added a community. When I went to the Overview tab for the new community, I got:

File '/Users/paul/Documents/workspace/KARL3/eggs/chameleon.core-1.0b36-py2.5.egg/chameleon/core/template.py', line 182 in cook_and_render
  return func(econtext, rcontext)
File '/Users/paul/Documents/workspace/KARL3/src/karl/karl/views/templates/community_layout.pt.py', line 533 in render
  _tmp(econtext)
File '/Users/paul/Documents/workspace/KARL3/src/karl/karl/views/templates/community.pt.py', line 225 in _callback_content
  _tmp2 = _lookup_attr(ri, 'modified_by_url')
File '/Users/paul/Documents/workspace/KARL3/eggs/chameleon.core-1.0b36-py2.5.egg/chameleon/core/codegen.py', line 33 in lookup_attr
  raise e
AttributeError: 'GridEntryInfo' object has no attribute 'modified_by_url'

[Paul Everitt (paul-agendaless)]

Problem can't be re-created.

[Nat Katin-Borland (nborland)]

There is an inconsistency here. On the Overview page, the latest person to edit a wiki is reflected properly in the Recent Activity box. The Active People list on the right hand navigation, however, is still reflecting the original wiki "creator." The Active People and Recent Activity should be the same or else it's confusing.

-Nat

[Paul Everitt (paul-agendaless)]

Changing status to in-progress. Shane, we don't necessarily have to fix this for tonight's rollout. OTOH, this might be a one-line change for the view data or ZPT.

[Shane Hathaway (shane-hathawaymix)]

Paul Everitt wrote:
> Changing status to in-progress. Shane, we don't necessarily have to fix
> this for tonight's rollout. OTOH, this might be a one-line change for
> the view data or ZPT.

I've checked in a fix and updated staging. Nat, please test it again.

Shane

[Nat Katin-Borland (nborland)]

Looks good now - thanks for the quick turn around!