code review does not set X-Launchpad-Notification-Type for initial request
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Undecided
|
Tim Penhey |
Bug Description
I'm trying to filter my code review requests into a separate folder. I looked at some of the headers when I submitted a comment on a review. And I saw these headers:
X-Launchpad-
X-Launchpad-
X-Launchpad-Branch: ~jameinel/
In-Reply-To: <email address hidden>
Reply-To: <email address hidden>
Message-Id: <email address hidden>
X-Launchpad-
I noticed the "Notification-Type" which seemed like a nice header to use to distinguish other emails (like bug reports, etc). However, when I went to submit a new branch for review, the headers were:
X-Launchpad-
Reply-To: <email address hidden>
Message-Id: <email address hidden>
X-Launchpad-
X-Launchpad-Branch: ~jameinel/
oddly, it still has some of the headers like Rationale, and the Branch. But no indication of code-review.
The only header I have to go on is that "Reply-To" ~= mp.*@code.
It would be really nice to have something clear.
Changed in launchpad-code: | |
assignee: | nobody → Tim Penhey (thumper) |
milestone: | none → 2.2.6 |
status: | New → Fix Committed |
Changed in launchpad-code: | |
status: | Fix Committed → Fix Released |
On Thu, 18 Jun 2009 09:16:58 John A Meinel wrote: Message- Rationale: Owner Notification- Type: code-review bzr/1.16- simple- win32 Project: bzr Project: bzr Message- Rationale: Owner bzr/1.17- extract- one-time launchpad. net
> Public bug reported:
>
> I'm trying to filter my code review requests into a separate folder. I
> looked at some of the headers when I submitted a comment on a review.
> And I saw these headers:
>
> X-Launchpad-
> X-Launchpad-
> X-Launchpad-Branch: ~jameinel/
> In-Reply-To:
> <email address hidden> Reply-To:
> <email address hidden>
> Message-Id: <email address hidden>
> X-Launchpad-
>
> I noticed the "Notification-Type" which seemed like a nice header to use
> to distinguish other emails (like bug reports, etc). However, when I
> went to submit a new branch for review, the headers were:
>
> X-Launchpad-
> Reply-To: <email address hidden>
> Message-Id: <email address hidden>
> X-Launchpad-
> X-Launchpad-Branch: ~jameinel/
>
> oddly, it still has some of the headers like Rationale, and the Branch.
> But no indication of code-review.
>
> The only header I have to go on is that "Reply-To" ~=
> mp.*@code.
It will be there once we roll out 2.2.6, but since this email is not generated
by the appservers, it doesn't have the edge code.