edit_acl.html should reindex

Bug #387974 reported by Paul Everitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
KARL3
Fix Released
Medium
Chris McDonough

Bug Description

ChrisRossi noticed that the edit_acl.html saves the security changes but doesn't trigger a reindex.

Tags: security
Tres Seaver (tseaver)
Changed in karl3:
status: New → In Progress
Revision history for this message
Tres Seaver (tseaver) wrote :

Fix commited on 'karl' trunk in r3258.

Please test on staging and close.

Changed in karl3:
assignee: Tres Seaver (tseaver) → Paul Everitt (paul-agendaless)
status: In Progress → Fix Committed
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Confirmed fixed.

Changed in karl3:
status: Fix Committed → Fix Released
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

ChrisR says, maybe not. Editing works, re-indexing, not so much.

Changed in karl3:
status: Fix Released → In Progress
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Re-assigning to Chris for more investigation on production, based on Tres's comment:

"""
I just verified manually that the changes to the ACL get propagated to
the 'allowed' index, as long as the changes involve the 'view' permission::

$ bin/debug
...
root['communities']['default'].docid
492927271
x = root['communities']['default'].docid
root.catalog['allowed']._rev_index[x]
OOSet(['group.KarlAdmin', 'group.KarlStaff', \
u'group.community:default:members', \
u'group.community:default:moderators'])

I then visited http://localhost:6543/communities/default/edit_acl.html,
and granted user 'phreddy' the 'view' permission. Back in the debugger::

root._p_jar.sync()
root.catalog['allowed']._rev_index[x]
OOSet(['group.KarlAdmin', 'group.KarlStaff', \
u'group.community:default:members', \
u'group.community:default:moderators', u'phreddy'])

So I don't know what "doesn't seem to be working" means.
"""

Changed in karl3:
assignee: Paul Everitt (paul-agendaless) → Chris Rossi (chris-archimedeanco)
Revision history for this message
Chris Rossi (chris-archimedeanco) wrote :

Tres just checked in a patch to also invalidate the catalog cache after reindexing. This fixes the behavior I was seeing.

Changed in karl3:
status: In Progress → Fix Committed
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

I think ChrisM asserted that this is busted. Assigning to him as part of the workflow overhaul.

Changed in karl3:
assignee: Chris Rossi (chris-archimedeanco) → Chris McDonough (chrism-plope)
milestone: m19 → m27
status: Fix Committed → Confirmed
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

Let's move this to next week.

Changed in karl3:
milestone: m27 → m28
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

ChrisM said this is fixed on his branch.

Changed in karl3:
status: Confirmed → Fix Committed
Revision history for this message
Paul Everitt (paul-agendaless) wrote :

I believe this one is working.

Changed in karl3:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.