table of contents diff is broken

Bug #387047 reported by Edward Betts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Open Library
Fix Released
High
Anand Chitipothu
Changed in openlibrary:
assignee: nobody → Anand Chitipothu (anandology)
importance: Undecided → Medium
status: New → Confirmed
Revision history for this message
Edward Betts (edwardbetts) wrote :

We should fix this after the October release.

Revision history for this message
George (george-archive) wrote :

Still broken. Is it easier now to fix given the simpler TOC implementation?

Changed in openlibrary:
milestone: none → upstream-to-www
Revision history for this message
George (george-archive) wrote :

Here's another example:

http://upstream.openlibrary.org/books/OL18929164M/Workshop_manual_for_B.M.C._2.2-litre_four-cylinder_high_speed_diesel_engine.?m=diff&b=2

Given the increased prominence of history/recent edits in the redesign, it would be good to fix this bug.

George (george-archive)
Changed in openlibrary:
milestone: upstream-to-www → upstream
importance: Medium → High
Revision history for this message
George (george-archive) wrote :
Revision history for this message
Anand Chitipothu (anandology) wrote :
Revision history for this message
George (george-archive) wrote :

Excellent!

Revision history for this message
George (george-archive) wrote :

Why is everything on separate lines? Readability?

Revision history for this message
George (george-archive) wrote :

And, it looks like your insertion of a blank TOC entry is counted as an update...

http://upstream.openlibrary.org/books/OL3819344M/Simulacres_et_simulation?m=diff&b=4

Would be good to either modify your addition of a blank "| |" or remove it from the diff.

Revision history for this message
Anand Chitipothu (anandology) wrote :

I think, the blank " | | " are coming from production. Added code to supress such entries from view, edit and diff.

Changed in openlibrary:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.