Implementation of "Command line action with themporary files or pipes"
Bug #386682 reported by
Juho Vepsäläinen
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Phatch |
Invalid
|
Undecided
|
Stani |
Bug Description
This patch implements https:/
Changed in phatch: | |
status: | Incomplete → Invalid |
To post a comment you must log in.
Juho, did you actually try this one? It is full of errors :-( get_layer( ).image) as a temporary file and pass its temporary name to the ,shell= True)
- your regular expressions (eg '!input!') are not right, please look up the right ones. Please compile the regular expressions and make them available as class attribute.
- never use image.filename, normally you would pass info['path'] as an argument but in this case both input and output need to be temporary files. Save the current pil image (photo.
re.sub('!input!', image.filename, command)
- Also don't use the deprecated os.system, but do:
from subprocess import call
call('command'
Hmmm... maybe it is better I do this. By the time I have explained all the errors, I've done it myself. In case you don't know how to do something it is better to ask before submitting the patch.
Thanks a lot anyway for trying! Really!