Tag page lists a private resource that shouldn't be visible

[Paul Everitt]

(Extracted from the comment at https://bugs.launchpad.net/karl3/+bug/385971/comments/1 )

This bug is related to the Wikipage acl bug at https://karl.soros.org/profiles/abegim//showtag/levinson

First, login as khelz via impersonation.

Next, go to a tag page:

  https://karl.soros.org/profiles/abegim//showtag/levinson

You see one resource listed. However, that resource shouldn't be visible to khelz as it is a wikipage in a private community for which khelz isn't a member.

** For extra credit, find the places that generate links with the double slashes. For example, the My Tags portlet on the profile has tag hyperlinks that all contain double slashes.

[Chris Rossi (chris-archimedeanco)]

Fix is committed and deployed on staging for evaluation. (Includes fix to remove double slashes from profile view.)

In the course of fixing this bug I did consolidate the three different showtag views to all use the same code, since maintaining three very similar but subtly different views was bound to get error prone. (In fact, I found an error in two of the views for generating the link to the tag users page.)

A little extra testing of tags in the three different contexts is probably in order: global, community and profile. This is to ensure there are no unintended side effects of the code consolidation.

[Paul Everitt (paul-agendaless)]

Confirmed fixed on staging.