shell test progress should include test name

Bug #386034 reported by Eitan Isaacson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox
Fix Released
Low
David Murphy

Bug Description

It would be helpful to see what test is currently being run. This is especially true when a long list of automated tests are being carried out. Instead of "Running shell tests..." there should be a more verbose message.

Related branches

Revision history for this message
Eitan Isaacson (eeejay) wrote :
Revision history for this message
Eitan Isaacson (eeejay) wrote :

Should I just commit this? Don't know!

Changed in checkbox:
status: New → Confirmed
Revision history for this message
Marc Tardif (cr3) wrote :

The original motivation for showing a static message instead of an interpolated message was that I thought it would look weird to have some string potentially changing more quickly than the user could read. However, you raise a valid concern which has also been expressed by apw. The long term solution would be to have a toggable terminal window showing the tests being run as well as their corresponding output. As for the short term solution, I'm quite comfortable with your proposed changes except that I would change the line to read:

interface.show_wait(_("Running test %s..." % test.name)

This would match the string currently defined in checkbox_gtk/gtk_interface.py and checkbox_cli/cli_interface.py when running a command from within a manual test. Feel free to push your changes to trunk.

Changed in checkbox:
assignee: nobody → Eitan Isaacson (eeejay)
importance: Undecided → Low
Revision history for this message
David Murphy (schwuk) wrote :

Applied the fix as identifed by Eitan and revised by Marc.

Changed in checkbox:
assignee: Eitan Isaacson (eeejay) → David Murphy (schwuk)
milestone: none → 0.9-featurefreeze
status: Confirmed → Fix Committed
Marc Tardif (cr3)
Changed in checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.