Hooks in failsafeX for VirtualBox contain a typo that prevents intended function

[Ryan Hamilton]

Binary package hint: xorg

Hi,

There's a typo in the released fix for bug #319373 that keeps it from it's intended result. In a vanilla 9.04 install, there is an extra space in the added line that causes the grep statement to fail and still default to vesa for the driver. On my system failsafeDexconf reads:

VBOX_VIDEO-$(grep -e "^vbox " /proc/modules || true)

where it should read

VBOX_VIDEO-$(grep -e "^vbox" /proc/modules || true)

It'd also be useful to change the modes available as well, using the same that are already written in for QEMU. I've changed on my system the line

if [ -n "$QEMU_KVM" ]; then

to

if [ -n "$QEMU_KVM" ] || [ -n "$VBOX_VIDEO" ]; then

and added an additional "1280x1024" mode so I can use it full screen on my desktop.

Thanks for putting in the previous changes! This is my first contribution to Ubuntu, and it was cool to see it changed so quickly.

[Bryce Harrington (bryce)]

Hi rthamilt,

Please attach the output of `lspci -vvnn`, and attach your /var/log/Xorg.0.log (and maybe Xorg.0.log.old) file from after reproducing this issue. If you've made any customizations to your /etc/X11/xorg.conf please attach that as well.

[This is an automated message. Apologies if it has reached you inappropriately; please just reply to this message indicating so.]

[Bryce Harrington (bryce)]

Expired