qbind command needed

[Ian Clatworthy]

Binding/unbinding in an important part of a unique feature to Bazaar: bound branches.

The qbind dialog can be a simple one, namely ...

  Branch: ________ (Browse)

with buttons of "Cancel" and "Bind".

If branch.get_old_bound_location() returns a value, the text entry field should be populated with it.

Implementation wise, I'd be tempted to reuse the code out of builtins.cmd_bind.run(), trapping the various exceptions and presenting the right message dialogs accordingly. (I don't think SubProcessDialog is worth it here.)

[Gary van der Merwe (garyvdm)]

On Tue, Jun 9, 2009 at 10:35 AM, Ian
Clatworthy<email address hidden> wrote:
> Implementation wise, I'd be tempted to reuse the code out of
> builtins.cmd_bind.run(), trapping the various exceptions and presenting
> the right message dialogs accordingly. (I don't think SubProcessDialog
> is worth it here.)

This probably should the same dialog as qswitch, and qswitch may need
to update files in the working tree, which may take a while. So
disagree - I think it makes sense to make it a SubProcessDialog.

[Javier Derderyan (javierder)]

bind is not the same that switch.
Bind only adds the new bound location, but doesn't update the working tree.
"Convert the current branch into a checkout of the supplied branch.
Once converted into a checkout, commits must succeed on the master branch before they will be applied to the local branch."

But in switch: "the working tree is updated and uncommitted changes are merged. The user can commit or revert these as they desire"

[Javier Derderyan (javierder)]

Ian, branch.get_old_bound_location() is the function you wanted to say?
It returns the branch "we used to be bound to", but if the working directory is currently bound but never "used to be bound to..." returns an empty string.

maybe you mean branch.get_bound_location()?

[Javier Derderyan (javierder)]

Ok, I just noticed the difference. get_old_bound_location is working with new branches types.