The pigment plugin depends on the poblesec plugin

Bug #385084 reported by Olivier Tilloy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Moovida
Fix Released
Medium
Olivier Tilloy

Bug Description

There is a direct circular dependency between the pigment and poblesec plugins.
The pigment plugin should not (directly or indirectly) depend on the poblesec plugin.

Steps to reproduce:

1) In a development branch, grep for "poblesec" in the pigment plugin:
    $ grep -rn --include="*.py" "poblesec" elisa-plugins/elisa/plugins/pigment/*

Expected result: empty output.

Current result:

elisa-plugins/elisa/plugins/pigment/dbus_frontend.py:47: path = "/poblesec"
elisa-plugins/elisa/plugins/pigment/pigment_frontend.py:753: main = self.retrieve_controllers('/poblesec')[0]
elisa-plugins/elisa/plugins/pigment/widgets/indicator_progressbar.py:173: full_indicator_resource = 'elisa.plugins.poblesec.folder'
elisa-plugins/elisa/plugins/pigment/widgets/style.py:17:from elisa.plugins.poblesec.notifying_dict import NotifyingDictionary
elisa-plugins/elisa/plugins/pigment/widgets/theme.py:192: #path_to_watch = "C:\Users\Anna\elisa\dev\relook_main_menu\elisa-plugins\elisa\plugins\poblesec"
elisa-plugins/elisa/plugins/pigment/widgets/theme.py:204: path_to_watch = r"C:\Users\Anna\elisa\dev\relook_main_menu\elisa-plugins\elisa\plugins\poblesec"

Olivier Tilloy (osomon)
Changed in elisa:
importance: Undecided → Medium
status: New → Confirmed
assignee: nobody → Olivier Tilloy (osomon)
Olivier Tilloy (osomon)
Changed in elisa:
status: Confirmed → In Progress
Olivier Tilloy (osomon)
Changed in elisa:
milestone: none → 1.0.4
Revision history for this message
Philippe Normand (philn) wrote :

One more poblesec little dep in pigment: widgets/data/osk_qwerty.xml which doesn't seem to be used anymore

Revision history for this message
Olivier Tilloy (osomon) wrote :

@Phil: indeed, I missed this one. I'll remove it.

Changed in elisa:
status: In Progress → Fix Committed
Olivier Tilloy (osomon)
Changed in elisa:
status: Fix Committed → In Progress
Olivier Tilloy (osomon)
Changed in elisa:
status: In Progress → Fix Committed
Olivier Tilloy (osomon)
Changed in elisa:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.