Rocketfuel build should fail if bzr C extensions not built

Bug #385040 reported by Jonathan Lange
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Stuart Bishop

Bug Description

Since we run the world's most popular Bazaar server, we should be offering our users the fastest possible service. To do this, we need to have C extensions built.

Although we do try to build C extensions (via Bazaar's normal build process), the build succeeds silently if the extensions are not built. Instead, it should fail noisily.

Revision history for this message
Jonathan Lange (jml) wrote :

This bug filled while working on bug 382795.

Revision history for this message
Jonathan Lange (jml) wrote :

Bug 385453 might be enough to solve this.

affects: launchpad → launchpad-foundations
Jonathan Lange (jml)
tags: added: build-infrastructure
removed: infrastructure
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Since the move to eggs, I have even less idea how to fix this bug.

Revision history for this message
Francis J. Lacoste (flacoste) wrote :

Well, we could simply add a check to load the bzr C module and fail with an appropriate error message if it can't be loaded.

Stuart Bishop (stub)
Changed in launchpad-foundations:
status: Triaged → In Progress
assignee: nobody → Stuart Bishop (stub)
Revision history for this message
Stuart Bishop (stub) wrote :

$ python
Python 2.6.2 (release26-maint, Apr 19 2009, 01:58:18)
[GCC 4.3.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import storm
>>> storm.has_cextensions
False
>>>

$ make harness
bin/harness
execute_zcml_for_scripts()...
xmlconfig.file()...
Reading $PYTHONSTARTUP...
Initializing storm...
Creating the factory...

>>> import storm
>>> storm.has_cextensions
True
>>>

Revision history for this message
Diogo Matsubara (matsubara) wrote : Bug fixed by a commit

Fixed in devel r9366.

Changed in launchpad-foundations:
status: In Progress → Fix Committed
Stuart Bishop (stub)
Changed in launchpad-foundations:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.