code review 'show diff' sends you off to download an unintelligble .txt file

[John A Meinel]

This may be related to bug #327135

For whatever reason, one of my submissions changed a bit.
https://code.edge.launchpad.net/~jameinel/bzr/1.16-no-first-delta-index/+merge/6991

It no longer shows a "review diff", but does give a link to "Diff against target".

I also noticed that the link is now orange and hovering says "Stale". I'm a bit unclear as to what has to happen for a merge to be considered "Stale", but perhaps it is related to why the "review diff" is no longer shown. (Or perhaps because someone reviewed it with 'Approve'? Though the overall state is still "Needs Review".)

Anyway, since the only way to see the diff now is the "Diff against target" link, I clicked it. Only instead of showing me the diff, it pops up a "save to disk" dialog. Personally, if I wanted to save it, I would have right-clicked and said "Save As". It at least claims to be a ".txt" and I've certainly directly viewed many .patch files that were attached to bugs, without having to context switch (save the file to disk, find the file on disk, open it up in my preferred editor, etc.) As the file is just '.txt' it doesn't give much control over what my preferred viewer is.

[Jonathan Lange (jml)]

It seems that lp:mad is not providing a high quality user experience.

Tim can provide some explanations about why the extension & mimetype of the 'diff against target' file is so poor.

Not sure why the review diff went away -- sounds like a separate issue though.

[Tim Penhey (thumper)]

This now scrolls you down to the diff below.

[Zooko Wilcox-O'Hearn (zooko)]

Hi, I seem to be having a similar problem. I was looking at this ticket: http://tahoe-lafs.org/trac/tahoe-lafs/ticket/1435 and I clicked on the launchpad Bug # which took me to https://bugs.launchpad.net/zope.interface/+bug/811792 . Then I saw a hyperlink with anchor text "Ready to review" so I clicked on that which took me to https://code.launchpad.net/~divmod-dev/divmod.org/811792-remove-formless/+merge/69186 . Now when I click "Diff against target" it

What the heck? When I did this a few minutes ago, it opened up a "Save As" dialog to download the text file. When I was reproducing it just now while typing this bug report it did, as Tim Penhey said on 2010-02-17, scroll me down to the diff that I was looking for at the bottom of the page. I'm pretty sure I did not do anything different.

Also, I have not been doing any drugs recently (except coffee).