sale_simple_pos obj_journal global object not defined

[Ana Juaristi Olalde]

This error is concerning sale_simple_pos new module included on community addons published 29-05-2009 by Raphaël Valyi - http://www.Smile.fr
https://code.launchpad.net/~openerp-community/openobject-addons/trunk-addons-community

1. Create a new order
2. Include a new line on it. Product has got one tax line.
3. prevalidate order, include paid amount (total or parcial is the same, error apears anyway)
4. create invoice:

  File "/home/cpu/openerp-server_new/branches/common/bin/addons/sale_payment/sale_payment.py", line 68, in _make_invoice
  File "/home/cpu/openerp-server/branches/common/bin/addons/sale_simple_pos/sale.py", line 162, in _make_invoice
    res = journal_obj.search(cr, uid, [('type', '=', 'sale'), ('company_id','=',order.user_id.company_id.id)], limit=1)
NameError: global name 'journal_obj' is not defined

Some feedback on this new module. There is little thinks would made the module much more useful.

1.- Including new lines directly on grid instead of opening a new window (as is on the official pos module)
2.- Including new report to print tickets, not only invoices
3.- Including a way to assign taxes to "ghost" product without having to click in a separate window.
4.- Having possibility of reading EAN13 code and product code with bar code readers.

I thing this is the standard sale order screen defining some anonymous values to make easier to register an order, but basically the functionality of a real pos interface is still missing. Nevertheless, thank you raphael for your work!!!

I think we should improve this real necesary module for little stores and companies who need going really quickly ticketing products. Imaging a supermarket. Something like this. The salesman read one code, other, other, other, take payment from an anonymous customer(effective or credit card), print ticket and goodbye :)

How can we do it? Is there someone who would offer a quotation for this work? Maybe Raphaël? Maybe, I would prefer modifying official pos module as it is nearer to my needs than sale orders module.

Thank you very much.

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hi Avanzosc,

thanks for the feedback, I'll consider you report.
About the sale_simple_pos module: our goal was to propose something simple and reliable to our customers (2 so far) wanting a simple sale interface for theirs shop where to sell only a few articles (like 50 sales per shop per day). So it's not like a real pos with touchscreen requirements but we had to propose something better than the basic sale interface.

Stay tuned.

Raphael Valyi

[Raphaël Valyi - http://www.akretion.com (rvalyi)]

Hi,

fixed in revision #51 of sale_simple_pos

Some comments:

1.- Including new lines directly on grid instead of opening a new window (as is on the official pos module)
Would be nice BUT we don't want to rewrite completely the sale order tree view.
So I think we should ask Tiny to provide a new way to extend view, that is ability to change a view attribute (here the tree editable attribute) without having to redefine the whole XML element as it is currently the case. That would help a lot in lot's of situations.

2.- Including new report to print tickets, not only invoices
Would be easy, taking inspiration from the official POS module.

3.- Including a way to assign taxes to "ghost" product without having to click in a separate window.
Don't understand, could you explain more?

4.- Having possibility of reading EAN13 code and product code with bar code readers.
I guess that wouldn't be too hard, but we will not do it ourself in the close future. Contributions are welcome though.

May be you can put all this in better shape in a blueprint? Anyway thanks for the report,

Raphaël Valyi

[Ana Juaristi Olalde (ajuaristio)]

Hi Raphael:

Nice to meet you.

1.- You are right. I think this will be a good blueprint. Maybe a new gadget or simply the availability of modifying a parameter on existing tree gadget to make it editable. I'm very very newbie on programming openerp so I even don't know if it exists by now or it is difficult changing a non editable tree form by an editable tree form.

2. Ok... yes that would be the right way.

3.- Don't understand, could you explain more?
Yes... if you include a product, when the windows is opened, there is the possibility not including a catalog registered product but a "ghost" product. You only have to type the description and quantity you want and without selecting any product you can add the line to the order. This is really useful when you are registering quotations. If product is registered you can assign taxes on his record and then taxes will be assigned automatically on order line, but if the product is not registered, you have to click on tax and then add the taxes, each time you add a ghost product. It's not a very big problem, but would be more comfortable if taxes were on same screen.

4.- Today a prospect customer and me have been evaluating the pos module, your sale_simple_pos module and the sale standard module. He has got an store and pos is the most important module he needs to sale. So we were comparing registering sales using all 3 different possibilities. I am charmed that all of them have the possibility of reading EAN13 code and product code with bar code reader. We have prove it with a real bar code reader, configuring EAN13 on product record. So, the requirement is included on standard application :)
You only have to put the cursor on product field and pass the reader across product bar code and it is found. It's great!!!

OK... so 2 and 3 points I think they are clearly a wishlist, not a bug at all but I don't know if they are important enough to open a blueprint. 4 is solved... Do you think it is really necessary to open a new blueprint? Maybe is better opening first an answer about the first point and it will be enough.

anyway... Thank you for your fast reply and the really fast solution on bug I reported!!! I'm sure we will be in contact again...