xfs package: /var/run/xfs/xfs.pid or /var/run/xfs.pid ?

[Eric Seigne]

Binary package hint: xfs

After installing xfs on jaunty (apt-get install xfs), /etc/init.d/xfs (re)start said

xfs[17684]: cannot fdopen process ID file /var/run/xfs/xfs.pid for writing: No such file or directory
xfs[17684]: error opening process ID file /var/run/xfs/xfs.pid

But /etc/init.d/xfs is configured to use /var/run/xfs.pid (PIDFILE=/var/run/xfs.pid) ... and it started xfs daemon with this command line:
start-stop-daemon --start --quiet --pidfile /var/run/xfs.pid --exec /usr/bin/xfs -- -daemon

So it seems to be a bug ?

[Bryce Harrington (bryce)]

Hi eric-seigne,

Please attach the output of `lspci -vvnn`, and attach your /var/log/Xorg.0.log (and maybe Xorg.0.log.old) file from after reproducing this issue. If you've made any customizations to your /etc/X11/xorg.conf please attach that as well.

[This is an automated message. Apologies if it has reached you inappropriately; please just reply to this message indicating so.]

[Eric Seigne (eric-seigne)]

Ok, this is really inappropriately :)

Éric

[Eric Seigne (eric-seigne)]

Okay,
here is a patch. Please replace 03_debian_piddir.diff with this one, then build package and try it ... it works.

With this patch, pidfile is /var/run/xfs.pid, maybe ubuntu/debian want it in /var/run/xfs ?

Éric

[Bryce Harrington (bryce)]

Hmm, actually I think the patch is not correct. I'd like to see this worked out with debian actually...

[Bilal Akhtar (bilalakhtar)]

Whenever you subscribe sponsors, please make sure that a proper debdiff is attached, not a patch that modifies only part of the package.

Instructions to create a debdiff: https://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff .

[Michael Vogt (mvo)]

Thanks a lot firstofall for the patch Eric and sorry that we took so long to review it.

I tested the package it on my natty system (maverick has the same version) and the bug appears to be fixed by now. Unfortunately the original bugreport does not have the version information of xfs.

Inspecting the init script it now says:

PIDDIR=/var/run/xfs
PIDFILE=$PIDDIR/xfs.pid

and also
set_up_pid_dir () {
  if [ ! -d "$PIDDIR" ] ; then
    mkdir $PIDDIR
    chown debian-xfs $PIDDIR
  fi
}

So that appears to be fine now. I will close the bug. Please reopen if I overlooked something.

[Bryce Harrington (bryce)]

On Mon, Nov 22, 2010 at 07:50:46AM -0000, Bilal Akhtar wrote:
> Whenever you subscribe sponsors, please make sure that a proper debdiff
> is attached, not a patch that modifies only part of the package.
>
> Instructions to create a debdiff:
> https://wiki.ubuntu.com/PackagingGuide/Recipes/Debdiff .

@Bilal, please see http://daniel.holba.ch/blog/?p=820