startsqueak can be improved

[Damien Cassou]

startsqueak is very good and a great idea. However the script can be improved a little. This are just ideas, feel free to close this bug if you don't like them.

[Damien Cassou (cassou)]

'-n' is true if string is not empty. Not not empty means empty so I replaced '! -n' by '-z'.

[Damien Cassou (cassou)]

Why not using ~/.squeak/ instead of ~/squeak/ ? Dotted files are more common for this sort of directories ?

[Damien Cassou (cassou)]

Here I used ${parameter:-word} which is replaced by 'parameter' if paramater is non null and non empty or by word on the other case.

[Damien Cassou (cassou)]

In your version, it seems one test if always true :

 for sourcef in $IMAGE_DIR/*.sources
 do
   locname=`basename $sourcef`
   if [ ! -f $locname ]
   then

$locname is just a filename without directory: you can't test for its existance because you don't know in which directory your script is executing.

Moreover, I replaced '-f' with '-e' because it is more general (a link answer false to '-f' and we are waiting for link files).

[LaserJock (laserjock)]

Thanks for all these patches. I will see if startsqueak can be merged into the Debian packages.

[Markus Schlager (m-slg)]

Why is startsqueak missing in hardy?

[Luke Faraone (lfaraone)]

This bug no longer affects lucid, as startsqueak has been replaced with squeak.