root tab close button complains when it shouldn't

[Robert Collins]

Open terminator, open a second terminal then a ctrl-alt-shift-t root tab window thingy.

click on close for that new one, it was a mistake you were just reading the man page.

bing! 'are you sure you want to do this, multiple processes yada yada yada' -> No
ctrl-D, it goes away.

[Frode Egeland (egeland)]

Attempted to replicate this on trunk, rev 735 as follows:
Opened terminator.
Split vertically via context menu.
Pressed Ctrl-Alt-Shift-T
Closed the tab that appeared using mouse on the tab's close button

Result:
Tab went away as expected, returning to the two original terminals. No 'are you sure' prompt or other error.

Conclusion:
The bug as reported didn't replicate for me. Perhaps I misunderstood the bug report?

[Chris Jones (cmsj)]

I think what's happening is that Rob is actually closing the wrong tab, so it's trying to close the one that does have multiple terminals in it.
Not really sure what we can do about this - arguably it's more a Gtk theme issue for not making the tabs clear enough.

Perhaps it would make sense to remove the tab close buttons on tab pages that aren't active?

[Frode Egeland (egeland)]

Removing the tab close button on inactive tabs would fix this, but I'm sure some people would then complain about that.

Given that the issue is that a genuine warning appears when the user is trying to close a tab with multiple terminals in it, I'd be tempted to call this "proper behaviour", rather than a bug.

A compromise might be to add an option to disable/remove the close button in the config.

[Chris Jones (cmsj)]

Oh!

Rob: are you using the extreme_tabs option? I dumbly assumed you were using ctrl-alt-shift-t as ctrl-alt-t, I forgot about extreme_tabs mode.

[Robert Collins (lifeless)]

On Mon, 2009-05-25 at 21:13 +0000, Chris Jones wrote:
> Oh!
>
> Rob: are you using the extreme_tabs option? I dumbly assumed you were
> using ctrl-alt-shift-t as ctrl-alt-t, I forgot about extreme_tabs mode.

I think so. Will let you know Sundayish when I'm home.

-Rob

[Robert Collins (lifeless)]

lets close this, I've tried to reproduce and can't.

 status invalid