Detect special login problems and alert

[Paul Everitt]

We heard from Nat that he gets lots of trouble tickets filed on login because people put a space at the end of their login by accident. Let's detect that and display an error message. Also display a different error message if there are any spaces (e.g. in the middle).

[Paul Everitt (paul-agendaless)]

Move to M15.

[Paul Everitt (paul-agendaless)]

Balazs said he would help me out of the mess I was going to make. Below is the diff for the direction I was going.

He plans to alter directions. Instead of going with the top-of-the-form message, he will try to do something directly on the field, like tagbox does (much better). He will also try to avoid the quagmire I got into by having an invisible div already present in the form.

$ svn diff src/karl/karl/views
Index: src/karl/karl/views/templates/login.pt
===================================================================
--- src/karl/karl/views/templates/login.pt (revision 2805)
+++ src/karl/karl/views/templates/login.pt (working copy)
@@ -7,16 +7,34 @@

     <div metal:use-macro="api.snippets.macros['status_message']"/>

+ <div class="portalMessage" style="display:none"></div>
     <form name="formLogin" method="post" action="${app_url}/login">

- <fieldset class="field">
+ <fieldset class="field" id="username-field">

        <span class="loginLabelWrapper">
           <label for="username">Username</label>
        </span>
        <input name="login" id="username" value="" size="30"
                tal:attributes="value username|nothing" />
-
+ <script language="javascript" type="text/javascript">
+ $(document).ready(function() {
+ // Some simple validators for common mistakes
+ $('input#username:first')
+ .change(function(e) {
+ alert($('input#username:first').size());
+ var msg1 = 'msg 1';
+ var pm = $('.portalMessage');
+ pm.css('display', 'none');
+ var newval = this.value;
+ if (newval == 'xxx') {
+ pm.text(msg1);
+ pm.css('display', 'block');
+ }
+ });
+ });
+ </script>
+ <span class="errorMessage"></span>
       </fieldset>

       <fieldset class="field">

[Paul Everitt (paul-agendaless)]

Per Jason, we should remove the part of the enhancement that blocks (with a message) a space in the middle. But we *keep* the detection of a space at the end.

Jason and Ajo are working on a longer-term writeup.

[Paul Everitt (paul-agendaless)]

Well, that didn't last long. Change of plan to the change of plan...remove everything that was done in support of this ticket. Nothing should be done to detect special login problems.

[Paul Everitt (paul-agendaless)]

Confirmed on staging.